Bug 111598

Summary: unable to install webkit-gtk +quartz 1.10 via MacPorts - Cairo WidgetBackingStore not linked in
Product: WebKit Reporter: Eric Le Lay <elelay>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: cgarcia, gustavo, jeremyhu, mcatanzaro, philip.chimento
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
URL: https://trac.macports.org/ticket/38203
Bug Depends on:    
Bug Blocks: 126492    
Attachments:
Description Flags
simply add the Quartz file if no X11 and not windows none

Eric Le Lay
Reported 2013-03-06 10:40:35 PST
Created attachment 191789 [details] simply add the Quartz file if no X11 and not windows See MacPorts ticket. webkit-gtk +quartz was building fine, but I had this error when using py27-webkit-gtk and midori. I've run port destroot again and launched the demo program GtkLauncher: it had the same problem. Here is the error: Process: GtkLauncher [79092] Path: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/webkit-gtk/work/webkitgtk-1.10.2/Programs/.libs/GtkLauncher Identifier: GtkLauncher Version: ??? (???) Code Type: X86-64 (Native) Parent Process: bash [79089] Date/Time: 2013-02-12 07:30:40.928 +0100 OS Version: Mac OS X 10.6.8 (10K549) Report Version: 6 Exception Type: EXC_BREAKPOINT (SIGTRAP) Exception Codes: 0x0000000000000002, 0x0000000000000000 Crashed Thread: 0 Dispatch queue: com.apple.main-thread Dyld Error Message: Symbol not found: __ZN7WebCore18WidgetBackingStore6createEP10_GtkWidgetRKNS_7IntSizeE Referenced from: /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_www_webkit-gtk/webkit-gtk/work/webkitgtk-1.10.2/.libs/libwebkitgtk-1.0.0.dylib Expected in: flat namespace I've managed to fix it by adding a previously excluded WebCore/platform/cairo/WidgetBackingStoreCairo.cpp to the build, which implemented the missing method. Please find the patch attached. It is simplistic because it's only applied when building for Quartz, not X11.
Attachments
simply add the Quartz file if no X11 and not windows (499 bytes, patch)
2013-03-06 10:40 PST, Eric Le Lay 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2014-01-12 07:41:48 PST
I think this file should probably be included unconditionally, in what configuration do we not use it?
Philip Chimento
Comment 2 2015-01-02 20:09:00 PST
This is fixed by my patch at https://bugs.webkit.org/show_bug.cgi?id=126821, is there any chance it could be reviewed for committing to the 2.4 branch for an eventual 2.4.8 release?
Jeremy Huddleston Sequoia
Comment 3 2015-01-08 14:24:09 PST
The attached patch no longer applies cleanly to 2.4.8, unfortunately.
Jeremy Huddleston Sequoia
Comment 4 2015-01-08 14:25:57 PST
Looking at Source/WebCore/GNUmakefile.list.am in 2.4.8, I wonder if this is still an issue. Looks like it might be fixed.
Philip Chimento
Comment 5 2015-01-08 16:43:37 PST
Yes, my patch at #126821 was included in 2.4.8. I think this can be closed now.
Note You need to log in before you can comment on or make changes to this bug.