Bug 111597 – WebKit does not build without accelerated compositing after Changeset 144823

• Component: New Bugs
• Status: RESOLVED FIXED

WebKit does not build without accelerated compositing after Changeset 144823

Created attachment 191788 [details]
Patch

Build error

Source/WebCore/page/scrolling/ScrollingCoordinator.cpp:297:108: error: no 'WebCore::GraphicsLayer* WebCore::ScrollingCoordinator::verticalScrollbarLayerForScrollableArea(WebCore::ScrollableArea*)' member function declared in class 'WebCore::ScrollingCoordinator'
make[1]: *** [Source/WebCore/page/scrolling/libWebCore_la-ScrollingCoordinator.lo] Błąd 1
make[1]: Opuszczenie katalogu `/home/pawel/src/webkit'
make: *** [all] Błąd 2

Changeset http://trac.webkit.org/changeset/144823
added ifdef to ScrollingCoordinator.h and ScrollingCoordinator.cpp
But turns out they dont match. Additionally it makes guards and fallback code introduced in changeset http://trac.webkit.org/changeset/144799 redundant.

Attached patch should adress those.

[WebKit Review Bot]

Attachment 191788 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp']" exit_code: 1
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Comment on attachment 191788 [details]
Patch

Obviously, the tab in ChangeLog needs to be fixed before landing.

Created attachment 191910 [details]
Fixed style issue

[Kentaro Hara]

Comment on attachment 191910 [details]
Fixed style issue

Thanks for the fix.

[WebKit Review Bot]

Comment on attachment 191910 [details]
Fixed style issue

Clearing flags on attachment: 191910

Committed r145041: <http://trac.webkit.org/changeset/145041>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.