Bug 111588

Summary: Use SkTypeface API directly, rather than (soon to be private) SkFontHost
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, d-r, junov, peter+ews, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Mike Reed
Reported 2013-03-06 09:27:43 PST
Use SkTypeface API directly, rather than (soon to be private) SkFontHost
Attachments
Patch (6.75 KB, patch)
2013-03-06 09:29 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (6.74 KB, patch)
2013-03-06 09:57 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (7.37 KB, patch)
2013-03-06 10:16 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (7.52 KB, patch)
2013-03-06 12:58 PST, Mike Reed 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2013-03-06 09:29:00 PST
Created attachment 191767 [details] Patch
WebKit Review Bot
Comment 2 2013-03-06 09:31:35 PST
Comment on attachment 191767 [details] Patch Attachment 191767 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17045275
Peter Beverloo (cr-android ews)
Comment 3 2013-03-06 09:39:05 PST
Comment on attachment 191767 [details] Patch Attachment 191767 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/17088001
WebKit Review Bot
Comment 4 2013-03-06 09:42:01 PST
Comment on attachment 191767 [details] Patch Attachment 191767 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17086065
Mike Reed
Comment 5 2013-03-06 09:57:42 PST
Created attachment 191780 [details] Patch
WebKit Review Bot
Comment 6 2013-03-06 10:04:02 PST
Comment on attachment 191780 [details] Patch Attachment 191780 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/17082245
Mike Reed
Comment 7 2013-03-06 10:16:35 PST
Created attachment 191783 [details] Patch
Mike Reed
Comment 8 2013-03-06 12:45:33 PST
PTAL
Stephen White
Comment 9 2013-03-06 12:50:57 PST
Comment on attachment 191783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191783&action=review Okie doke. r=me > Source/WebCore/ChangeLog:8 > + No new tests. existing tests apply Nit: please indicate which ones.
Mike Reed
Comment 10 2013-03-06 12:58:55 PST
Created attachment 191814 [details] Patch
Mike Reed
Comment 11 2013-03-06 12:59:30 PST
updated changelog to specify some of the layouttests that exercise the table getter code.
Stephen White
Comment 12 2013-03-06 12:59:40 PST
Comment on attachment 191814 [details] Patch Great, thanks! r=me
WebKit Review Bot
Comment 13 2013-03-06 13:40:25 PST
Comment on attachment 191814 [details] Patch Clearing flags on attachment: 191814 Committed r144976: <http://trac.webkit.org/changeset/144976>
WebKit Review Bot
Comment 14 2013-03-06 13:40:29 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.