Bug 111588

Summary: Use SkTypeface API directly, rather than (soon to be private) SkFontHost
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, d-r, junov, peter+ews, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Mike Reed 2013-03-06 09:27:43 PST 
Use SkTypeface API directly, rather than (soon to be private) SkFontHost
Comment 1 Mike Reed 2013-03-06 09:29:00 PST 
Created attachment 191767 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-06 09:31:35 PST 
Comment on attachment 191767 [details]
Patch

Attachment 191767 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17045275
Comment 3 Peter Beverloo (cr-android ews) 2013-03-06 09:39:05 PST 
Comment on attachment 191767 [details]
Patch

Attachment 191767 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17088001
Comment 4 WebKit Review Bot 2013-03-06 09:42:01 PST 
Comment on attachment 191767 [details]
Patch

Attachment 191767 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17086065
Comment 5 Mike Reed 2013-03-06 09:57:42 PST 
Created attachment 191780 [details]
Patch
Comment 6 WebKit Review Bot 2013-03-06 10:04:02 PST 
Comment on attachment 191780 [details]
Patch

Attachment 191780 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17082245
Comment 7 Mike Reed 2013-03-06 10:16:35 PST 
Created attachment 191783 [details]
Patch
Comment 8 Mike Reed 2013-03-06 12:45:33 PST 
PTAL
Comment 9 Stephen White 2013-03-06 12:50:57 PST 
Comment on attachment 191783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191783&action=review

Okie doke.  r=me

> Source/WebCore/ChangeLog:8
> +        No new tests. existing tests apply

Nit:  please indicate which ones.
Comment 10 Mike Reed 2013-03-06 12:58:55 PST 
Created attachment 191814 [details]
Patch
Comment 11 Mike Reed 2013-03-06 12:59:30 PST 
updated changelog to specify some of the layouttests that exercise the table getter code.
Comment 12 Stephen White 2013-03-06 12:59:40 PST 
Comment on attachment 191814 [details]
Patch

Great, thanks!  r=me
Comment 13 WebKit Review Bot 2013-03-06 13:40:25 PST 
Comment on attachment 191814 [details]
Patch

Clearing flags on attachment: 191814

Committed r144976: <http://trac.webkit.org/changeset/144976>
Comment 14 WebKit Review Bot 2013-03-06 13:40:29 PST 
All reviewed patches have been landed.  Closing bug.