| Summary: | Token 'not' is ignored in the offlineasm | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peter Gal <galpeter> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | fpizlo, mark.lam, ossy, webkit.review.bot, zherczeg | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | 90740 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Created attachment 191733 [details]
Fix in the parser
This is the fix, to build the Not AST node in the parser.
(In reply to comment #1) > Created an attachment (id=191733) [details] > Fix in the parser > > This is the fix, to build the Not AST node in the parser. For this patch in the bug #90740 is needed, without that the generation of llint will fail. Oh.. just one thing: the 'not' is never used in the input .asm files, so that's why this wasn't spotted before. ping? Anyone up for a review? Comment on attachment 191733 [details]
Fix in the parser
Sorry it took so long! Thanks for this fix. r=me.
Comment on attachment 191733 [details] Fix in the parser Clearing flags on attachment: 191733 Committed r145689: <http://trac.webkit.org/changeset/145689> All reviewed patches have been landed. Closing bug. |
The token 'not' is ignored in the offlineasm, thus no AST is built for it. This is the relevant code part: def parsePredicateAtom if @tokens[@idx] == "not" @idx += 1 parsePredicateAtom elsif @tokens[@idx] == "(" ...