Bug 111568

Summary: Token 'not' is ignored in the offlineasm
Product: WebKit Reporter: Peter Gal <galpeter>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, mark.lam, ossy, webkit.review.bot, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 90740    
Bug Blocks:    
Attachments:
Description Flags
Fix in the parser none

Peter Gal
Reported 2013-03-06 05:39:29 PST
The token 'not' is ignored in the offlineasm, thus no AST is built for it. This is the relevant code part: def parsePredicateAtom if @tokens[@idx] == "not" @idx += 1 parsePredicateAtom elsif @tokens[@idx] == "(" ...
Attachments
Fix in the parser (1.22 KB, patch)
2013-03-06 05:46 PST, Peter Gal 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Gal
Comment 1 2013-03-06 05:46:10 PST
Created attachment 191733 [details] Fix in the parser This is the fix, to build the Not AST node in the parser.
Peter Gal
Comment 2 2013-03-06 05:49:14 PST
(In reply to comment #1) > Created an attachment (id=191733) [details] > Fix in the parser > > This is the fix, to build the Not AST node in the parser. For this patch in the bug #90740 is needed, without that the generation of llint will fail.
Peter Gal
Comment 3 2013-03-06 06:01:27 PST
Oh.. just one thing: the 'not' is never used in the input .asm files, so that's why this wasn't spotted before.
Peter Gal
Comment 4 2013-03-10 10:21:43 PDT
ping?
Peter Gal
Comment 5 2013-03-13 01:40:43 PDT
Anyone up for a review?
Filip Pizlo
Comment 6 2013-03-13 01:42:11 PDT
Comment on attachment 191733 [details] Fix in the parser Sorry it took so long! Thanks for this fix. r=me.
WebKit Review Bot
Comment 7 2013-03-13 02:09:59 PDT
Comment on attachment 191733 [details] Fix in the parser Clearing flags on attachment: 191733 Committed r145689: <http://trac.webkit.org/changeset/145689>
WebKit Review Bot
Comment 8 2013-03-13 02:10:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.