Bug 111552 – [WK2] Add new callbacks and a function for WebKit2 context menu API

• Component: WebKit2
• Status: RESOLVED FIXED

[Michal Pakula vel Rutka]

This patch will add two callbacks for showing and hiding context menus and an API function for selecting context menu items.

[Michal Pakula vel Rutka]

Created attachment 191704 [details]
proposed patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Kenneth Rohde Christiansen]

Comment on attachment 191704 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191704&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:871
> +void WKPageContextMenuItemSelected(WKPageRef page, WKContextMenuItemRef item)

the name gives me the idea that it will return a bool (Selected). Should this be called WKPageSelectContextMenuItem( ??

[Kenneth Rohde Christiansen]

Cc'ing some owners who might have comments

[Michal Pakula vel Rutka]

(In reply to comment #3)
> (From update of attachment 191704 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191704&action=review
> 
> > Source/WebKit2/UIProcess/API/C/WKPage.cpp:871
> > +void WKPageContextMenuItemSelected(WKPageRef page, WKContextMenuItemRef item)
> 
> the name gives me the idea that it will return a bool (Selected). Should this be called WKPageSelectContextMenuItem( ??

OK, I will change it to WKPageSelectContextMenuItem

[Michal Pakula vel Rutka]

Created attachment 194844 [details]
fixes

[Michal Pakula vel Rutka]

Created attachment 195303 [details]
fixes

fixed conditional in WebPagProxy

[Build Bot]

Comment on attachment 195303 [details]
fixes

Attachment 195303 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17221833

[Michal Pakula vel Rutka]

(In reply to comment #8)
> (From update of attachment 195303 [details])
> Attachment 195303 [details] did not pass win-ews (win):
> Output: http://webkit-commit-queue.appspot.com/results/17221833

The patch does not change WebKit1 code, so this is a false positive error.

[Carlos Garcia Campos]

Comment on attachment 195303 [details]
fixes

This looks good to me. What port does need this? Callbacks are unimplemented in both EFL and GTK+, or is it implemented in a another patch?

[Michal Pakula vel Rutka]

(In reply to comment #10)
> (From update of attachment 195303 [details])
> This looks good to me. What port does need this? Callbacks are unimplemented in both EFL and GTK+, or is it implemented in a another patch?

They are implemented in EFL port in https://bugs.webkit.org/show_bug.cgi?id=109698.

[Anders Carlsson]

Comment on attachment 195303 [details]
fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=195303&action=review

> Source/WebKit2/UIProcess/WebPageContextMenuClient.cpp:107
> +        menuItems.append(WebContextMenuItem::create(menuItemsVector[i]).get());

This should be uncheckedAppend.

[Michal Pakula vel Rutka]

Created attachment 197846 [details]
applied andersca's comment

[WebKit Commit Bot]

Comment on attachment 197846 [details]
applied andersca's comment

Clearing flags on attachment: 197846

Committed r148420: <http://trac.webkit.org/changeset/148420>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.