Summary: | [WK2] Add new callbacks and a function for WebKit2 context menu API | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||||||||
Component: | WebKit2 | Assignee: | Michal Pakula vel Rutka <mpakulavelrutka> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | andersca, ap, benjamin, cgarcia, commit-queue, gustavo, gyuyoung.kim, kenneth, mrobinson, rakuco, sam, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 109698, 113582 | ||||||||||||
Attachments: |
|
Description
Michal Pakula vel Rutka
2013-03-06 03:15:35 PST
Created attachment 191704 [details]
proposed patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 191704 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=191704&action=review > Source/WebKit2/UIProcess/API/C/WKPage.cpp:871 > +void WKPageContextMenuItemSelected(WKPageRef page, WKContextMenuItemRef item) the name gives me the idea that it will return a bool (Selected). Should this be called WKPageSelectContextMenuItem( ?? Cc'ing some owners who might have comments (In reply to comment #3) > (From update of attachment 191704 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191704&action=review > > > Source/WebKit2/UIProcess/API/C/WKPage.cpp:871 > > +void WKPageContextMenuItemSelected(WKPageRef page, WKContextMenuItemRef item) > > the name gives me the idea that it will return a bool (Selected). Should this be called WKPageSelectContextMenuItem( ?? OK, I will change it to WKPageSelectContextMenuItem Created attachment 194844 [details]
fixes
Created attachment 195303 [details]
fixes
fixed conditional in WebPagProxy
Comment on attachment 195303 [details] fixes Attachment 195303 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17221833 (In reply to comment #8) > (From update of attachment 195303 [details]) > Attachment 195303 [details] did not pass win-ews (win): > Output: http://webkit-commit-queue.appspot.com/results/17221833 The patch does not change WebKit1 code, so this is a false positive error. Comment on attachment 195303 [details]
fixes
This looks good to me. What port does need this? Callbacks are unimplemented in both EFL and GTK+, or is it implemented in a another patch?
(In reply to comment #10) > (From update of attachment 195303 [details]) > This looks good to me. What port does need this? Callbacks are unimplemented in both EFL and GTK+, or is it implemented in a another patch? They are implemented in EFL port in https://bugs.webkit.org/show_bug.cgi?id=109698. Comment on attachment 195303 [details] fixes View in context: https://bugs.webkit.org/attachment.cgi?id=195303&action=review > Source/WebKit2/UIProcess/WebPageContextMenuClient.cpp:107 > + menuItems.append(WebContextMenuItem::create(menuItemsVector[i]).get()); This should be uncheckedAppend. Created attachment 197846 [details]
applied andersca's comment
Comment on attachment 197846 [details] applied andersca's comment Clearing flags on attachment: 197846 Committed r148420: <http://trac.webkit.org/changeset/148420> All reviewed patches have been landed. Closing bug. |