Bug 111548

Summary: Web Inspector: test that "importScript" is used only in module heads.
Product: WebKit Reporter: Andrey Lushnikov <lushnikov>
Component: Web Inspector (Deprecated)Assignee: Andrey Lushnikov <lushnikov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Andrey Lushnikov 2013-03-06 02:16:56 PST 
Test that "importScript" function is called only in module heads to avoid bugs like https://bugs.webkit.org/show_bug.cgi?id=111535
Comment 1 Andrey Lushnikov 2013-03-06 03:08:37 PST 
Created attachment 191701 [details]
Patch
Comment 2 Pavel Feldman 2013-03-06 03:10:40 PST 
Comment on attachment 191701 [details]
Patch

You want to raise exception here, not exit.
Comment 3 Andrey Lushnikov 2013-03-06 03:24:13 PST 
This will exit with exitcode = 1 and error message. In the nutshell it raises SystemExit exception - so what's the difference?
Comment 4 Andrey Lushnikov 2013-03-06 03:39:32 PST 
Created attachment 191706 [details]
Patch
Comment 5 WebKit Review Bot 2013-03-06 07:23:06 PST 
Comment on attachment 191706 [details]
Patch

Clearing flags on attachment: 191706

Committed r144926: <http://trac.webkit.org/changeset/144926>
Comment 6 WebKit Review Bot 2013-03-06 07:23:10 PST 
All reviewed patches have been landed.  Closing bug.