Bug 111542

Summary:

[BlackBerry] Use the new authenticationChallenge API in WebPage

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

mifenton, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Carlos Garcia Campos 2013-03-06 01:14:55 PST

It's still using the old API.

Comment 1 Carlos Garcia Campos 2013-03-06 01:18:18 PST

Created attachment 191682 [details]
Patch

Comment 2 Rob Buis 2013-03-06 06:00:51 PST

Comment on attachment 191682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191682&action=review

> Source/WebKit/blackberry/Api/WebPage.cpp:2196
> +    BlackBerry::Platform::String requestURL(url.string());

Do we need a variable for this as we only use it once?

Comment 3 Rob Buis 2013-03-06 11:07:04 PST

Comment on attachment 191682 [details]
Patch

Ok.

Comment 4 WebKit Review Bot 2013-03-06 11:33:15 PST

Comment on attachment 191682 [details]
Patch

Clearing flags on attachment: 191682

Committed r144955: <http://trac.webkit.org/changeset/144955>

Comment 5 WebKit Review Bot 2013-03-06 11:33:18 PST

All reviewed patches have been landed.  Closing bug.