Bug 111530

Summary: [EFL][WK2] Use Vector::reserveInitialCapacity() in WebEventFactory::createWebTouchEvent()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit EFLAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, enmi.lee, gyuyoung.kim, kenneth, laszlo.gombos, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
benjamin: review+, benjamin: commit-queue-
Patch for landing none

Chris Dumez
Reported 2013-03-05 23:55:46 PST
In WebEventFactory::createWebTouchEvent(), when constructor the vector of touch points, we already know in advance the total number of touch points. Therefore, we should leverage WTF::Vector::reserveCapacity() and WTF::Vector::uncheckedAppend() to save some capacity checks.
Attachments
Patch (2.51 KB, patch)
2013-03-05 23:59 PST, Chris Dumez 		benjamin: review+
benjamin: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (2.53 KB, patch)
2013-03-06 00:58 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-03-05 23:59:48 PST
Created attachment 191662 [details] Patch
Benjamin Poulain
Comment 2 2013-03-06 00:53:51 PST
Comment on attachment 191662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191662&action=review Why not... > Source/WebKit2/Shared/efl/WebEventFactory.cpp:225 > + touchPoints.reserveCapacity(eina_list_count(points)); This should be reserveInitialCapacity.
Chris Dumez
Comment 3 2013-03-06 00:58:32 PST
Created attachment 191676 [details] Patch for landing
WebKit Review Bot
Comment 4 2013-03-06 01:29:50 PST
Comment on attachment 191676 [details] Patch for landing Clearing flags on attachment: 191676 Committed r144898: <http://trac.webkit.org/changeset/144898>
WebKit Review Bot
Comment 5 2013-03-06 01:29:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.