Bug 111523

Summary: [Custom Elements] CustomElementConstructor::m_name doesn't have any good use
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, esprehn+autocc, haraken, japhet, ojan.autocc, webcomponents-bugzilla, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Hajime Morrita 2013-03-05 22:12:18 PST 
It is just a historial remaining and should be renamed. m_tagName should become m_name instead.
Comment 1 Hajime Morrita 2013-03-05 22:43:33 PST 
Created attachment 191655 [details]
Patch
Comment 2 Kentaro Hara 2013-03-05 22:46:26 PST 
Comment on attachment 191655 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191655&action=review

Looks OK.

> Source/WebCore/ChangeLog:3
> +        [Custom Elements] CustomElementConstructor::m_name doesn't have any good use.

I was told to use [X] only for port names. You can use "Custom Elements:" from your next patch.
Comment 3 Hajime Morrita 2013-03-05 22:49:31 PST 
(In reply to comment #2)
> 
> I was told to use [X] only for port names. You can use "Custom Elements:" from your next patch.
Got it. Will do so in the landing patch too.
Comment 4 Hajime Morrita 2013-03-05 22:51:11 PST 
Created attachment 191656 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-03-05 23:55:53 PST 
Comment on attachment 191656 [details]
Patch for landing

Clearing flags on attachment: 191656

Committed r144889: <http://trac.webkit.org/changeset/144889>
Comment 6 WebKit Review Bot 2013-03-05 23:55:57 PST 
All reviewed patches have been landed.  Closing bug.