Bug 111503

Summary: Replace shouldLazyAttach bool with an enum for readability
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, eric.carlson, esprehn+autocc, feature-media-reviews, haraken, japhet, jer.noble, koivisto, mifenton, ojan.autocc, philn, rniwa, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Eric Seidel (no email)
Reported 2013-03-05 17:41:31 PST
Replace shouldLazyAttach bool with an enum for readabiliyt
Attachments
Patch (43.32 KB, patch)
2013-03-05 17:42 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (48.56 KB, patch)
2013-03-05 17:50 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (52.88 KB, patch)
2013-03-05 19:06 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (53.38 KB, patch)
2013-03-05 20:02 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (55.08 KB, patch)
2013-03-05 23:23 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2013-03-05 17:42:04 PST
Created attachment 191619 [details] Patch
Eric Seidel (no email)
Comment 2 2013-03-05 17:43:24 PST
Comment on attachment 191619 [details] Patch Build error. new patch coming.
Eric Seidel (no email)
Comment 3 2013-03-05 17:50:32 PST
Created attachment 191621 [details] Patch
Dimitri Glazkov (Google)
Comment 4 2013-03-05 17:55:22 PST
Comment on attachment 191621 [details] Patch wuv.
Eric Seidel (no email)
Comment 5 2013-03-05 19:06:48 PST
Created attachment 191636 [details] Patch
Eric Seidel (no email)
Comment 6 2013-03-05 19:07:13 PST
Sorry, I cleared your review. HOpefully this fixes Gtk.
Dimitri Glazkov (Google)
Comment 7 2013-03-05 19:56:39 PST
Comment on attachment 191636 [details] Patch I got your back!
Eric Seidel (no email)
Comment 8 2013-03-05 20:02:13 PST
Created attachment 191641 [details] Patch for landing
Eric Seidel (no email)
Comment 9 2013-03-05 20:02:57 PST
Comment on attachment 191641 [details] Patch for landing Waiting for gtk-ews to roll clean.
Build Bot
Comment 10 2013-03-05 21:22:26 PST
Comment on attachment 191641 [details] Patch for landing Attachment 191641 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16989147
Eric Seidel (no email)
Comment 11 2013-03-05 23:23:07 PST
Created attachment 191659 [details] Patch for landing
WebKit Review Bot
Comment 12 2013-03-06 00:01:22 PST
Comment on attachment 191659 [details] Patch for landing Clearing flags on attachment: 191659 Committed r144891: <http://trac.webkit.org/changeset/144891>
WebKit Review Bot
Comment 13 2013-03-06 00:01:27 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.