Bug 111487 – Objective-C API: JSValue should implement init and return nil in exceptional cases

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Mark Hahnenberg]

In keeping with good Objective-C practice, JSValue should override init and throw an exception since there's not really a way to put the returned object in a coherent state that won't crash at some point later in time. Better to fail fast.

[Mark Hahnenberg]

Created attachment 191576 [details]
patch

[Mark Hahnenberg]

<rdar://problem/13351901>

[Darin Adler]

Comment on attachment 191576 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191576&action=review

> Source/JavaScriptCore/API/JSValue.mm:955
> +    @throw [NSException exceptionWithName:@"InvalidMessageException"
> +                        reason:@"JSValue cannot safely support init."
> +                        userInfo:nil];

Why throw? Just return nil. And the initWithValue method should also return nil when the arguments are nil. That’s how Cocoa init functions normally work. Unless I’m missing some compelling argument for throwing exceptions instead.

Please don’t align the lines like this. WebKit coding style says just indent 4 spaces.

[Mark Hahnenberg]

Created attachment 191579 [details]
return nil

[Mark Hahnenberg]

Comment on attachment 191579 [details]
return nil

Need to update ChangeLog.

[Mark Hahnenberg]

Created attachment 191582 [details]
updated change log

[WebKit Review Bot]

Comment on attachment 191582 [details]
updated change log

Clearing flags on attachment: 191582

Committed r144843: <http://trac.webkit.org/changeset/144843>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.