Bug 111476
| Summary: | Getting the descriptor selectionDirection throws error | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Erik Arvidsson <arv> |
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, haraken, oliver, rniwa, zcorpan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 49739 | ||
| Bug Blocks: | |||
Erik Arvidsson
var checkbox = document.createElement('input');
input.type = 'checkbox';
Object.getOwnPropertyDescriptor(input, 'selectionDirection'); // THROWS!
It is OK to throw when we try to get the value of the selectionDirection but is an ES5 spec violation to throw on getting the descriptor.
This is most likely because we report WebIDL attributes as data properties, and as such, we read the value of the property.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Simon Pieters (:zcorpan)
Proposed spec change to not throw on getting: https://github.com/whatwg/html/pull/1006
Chris Dumez
This is apparently fixed on WebKit trunk:
var input = document.createElement('input');
input.type = 'checkbox';
Object.getOwnPropertyDescriptor(input, 'selectionDirection');
-> returns undefined
Object.getOwnPropertyDescriptor(input.__proto__, 'selectionDirection');
-> returns {get: function, set: function, enumerable: true, configurable: true}
Feel free to reopen if I missed something.
Chris Dumez
(In reply to comment #1)
> Proposed spec change to not throw on getting:
> https://github.com/whatwg/html/pull/1006
Oh, this does not seem strictly related to this bug. While WebKit no longer throws on getting the descriptor, accessing input.selectionDirection will throws.
Simon Pieters (:zcorpan)
Right, filed https://bugs.webkit.org/show_bug.cgi?id=156500