Bug 111453

Summary: Elevate accessors of C-SPI API variants to Objective-C SPI
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Description Sam Weinig 2013-03-05 10:16:48 PST
Elevate accessors of C-SPI API variants to Objective-C SPI
Comment 1 Sam Weinig 2013-03-05 10:18:07 PST
Created attachment 191510 [details]
Patch
Comment 2 WebKit Review Bot 2013-03-05 10:25:29 PST
Attachment 191510 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/ObjCObjectGraphCoders.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextControllerPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroupInternal.h', u'Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h', u'Source/WebKit2/UIProcess/API/mac/WKView.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm', u'Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h']" exit_code: 1
Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroupPrivate.h:28:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInPrivate.h:30:  Extra space before ( in function call  [whitespace/parens] [4]
Source/WebKit2/UIProcess/API/mac/WKProcessGroupPrivate.h:28:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2013-03-05 10:28:39 PST
Committed r144777: <http://trac.webkit.org/changeset/144777>