Bug 111450

Summary: GetnUniform*vEXT (Robustness extension) passed incorrect parameter in WebGLRenderingContext
Product: WebKit Reporter: R S <rsarvaria>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, esprehn+autocc, ojan.autocc, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description R S 2013-03-05 09:39:55 PST 
According to the robustness spec, GetnUniform*vEXT expects a parameter "sizei bufSize" which sets the number of bytes to be written. In the current implementation they pass the maximum number of entries that can be written instead of the amount of bytes.
Comment 1 R S 2013-03-05 11:16:33 PST 
Created attachment 191517 [details]
Patch
Comment 2 R S 2013-03-06 07:55:11 PST 
Created attachment 191751 [details]
Patch
Comment 3 R S 2013-03-06 09:54:38 PST 
Created attachment 191779 [details]
Patch
Comment 4 Rob Buis 2013-03-06 11:10:42 PST 
Comment on attachment 191779 [details]
Patch

Is there some scenario where the problem is shown? Ideal would be if there was a test showing the problem.
Comment 5 R S 2013-03-06 12:13:29 PST 
It showed up in the DRT test fast/canvas/webgl/gl-object-get-calls.html
Comment 6 Rob Buis 2013-03-07 11:28:20 PST 
(In reply to comment #5)
> It showed up in the DRT test fast/canvas/webgl/gl-object-get-calls.html

What effect does your change have on this test? Is it an improvement? If the test result is different you may need to add the new test result to your patch.
Comment 7 R S 2013-03-11 10:40:35 PDT 
There is no change to the actual test.
Comment 8 Rob Buis 2013-03-11 11:32:16 PDT 
(In reply to comment #7)
> There is no change to the actual test.

Ok, then we need to go back to your earlier remark:

> It showed up in the DRT test fast/canvas/webgl/gl-object-get-calls.html

How did it show up, as a warning?
Comment 9 Rob Buis 2013-03-11 12:42:12 PDT 
Comment on attachment 191779 [details]
Patch

Ok.
Comment 10 WebKit Review Bot 2013-03-11 12:52:11 PDT 
Comment on attachment 191779 [details]
Patch

Clearing flags on attachment: 191779

Committed r145387: <http://trac.webkit.org/changeset/145387>
Comment 11 WebKit Review Bot 2013-03-11 12:52:15 PDT 
All reviewed patches have been landed.  Closing bug.