Bug 111444 – [BlackBerry] FatFinger pairs the wrong element with fatfinger rect part

• Component: UI Events
• Status: RESOLVED FIXED

[Tiancheng Jiang]

When we do the fatfinger and try to findIntersectingRegions, we use fatfinger rect subtract element area, which end up we pair the wrong fatfinger rect part, which is outside the chosen element area, with the chosen element. This result adjustedposition is outside of the chosen element.

[Tiancheng Jiang]

Created attachment 191505 [details]
Patch

[Rob Buis]

Comment on attachment 191505 [details]
Patch

Ok.

[Antonio Gomes]

Comment on attachment 191505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191505&action=review

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:382
> -            remainingFingerRegion = subtractRegions(remainingFingerRegion, layerRegion);
> +            remainingFingerRegion = intersectRegions(remainingFingerRegion, layerRegion);

that is not right. what does it fix?

[WebKit Review Bot]

Comment on attachment 191505 [details]
Patch

Clearing flags on attachment: 191505

Committed r144771: <http://trac.webkit.org/changeset/144771>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Tiancheng Jiang]

If we use remainingFingerRegion subtract layerRegion, which will give us a region outside of layerRegion. But when we do checkFingerIntersection, we pair this region with the layer element. This end up a mismatch pair.
We should pair the intersected part with the layerRegion element.

(In reply to comment #3)
> (From update of attachment 191505 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191505&action=review
> 
> > Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:382
> > -            remainingFingerRegion = subtractRegions(remainingFingerRegion, layerRegion);
> > +            remainingFingerRegion = intersectRegions(remainingFingerRegion, layerRegion);
> 
> that is not right. what does it fix?