Summary: | Provide hooks for link click modifiers for Windows embedders | ||
---|---|---|---|
Product: | WebKit | Reporter: | Don Gibson <dgibson77> |
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> |
Status: | ASSIGNED --- | ||
Severity: | Normal | CC: | bugs-webkit |
Priority: | P2 | ||
Version: | 420+ | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Bug Depends on: | 11138, 11139 | ||
Bug Blocks: |
Description
Don Gibson
2006-10-03 16:42:52 PDT
It looks like maybe the right way to go here is to add code to WebKit/COM/WebFrame.cpp to call off to checkNavigationPolicyForRequest(). Then embedders will have to implement IWebPolicyDelegate, and in this action, decide how to handle such calls (perhaps by creating another instance and displaying it somewhere appropriate, and telling the original instance to do nothing?). The Mac version of this code is a bit convoluted, so it's still not totally clear to me where exactly the frame should be making this call. Looks like Dex Deacon is also wanting to hook up PolicyDelegate stuff in bug 11139, so there's going to be overlap between this bug and that I'm not sure this bug is very useful, given the lack of concrete forward direction. I think it's a good idea to unify this sort of click/keyboard handling logic, at least where it affects navigation. It's possible this could be pushed into a platform-specific class, or even the Chrome client. Without a specific proposal for which hooks you'd like to see though, I'm not sure it's worth keeping this bug around. |