Summary: | SVG preserveAspectRatio=none is not honored. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Philip Rogers <pdr> | ||||||
Component: | SVG | Assignee: | Sergio Correia (qrwteyrutiyoup) <sergio> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, jonlee, jsc456, kondapallykalyan, matthias.jost, m.goleb+bugzilla, schenney, sergio, simon.fraser, steveshaw, thorton, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Philip Rogers
2013-03-04 20:39:04 PST
Do we already now, why this worked in previous versions? Thank you for your support so far. How long will it approximately take to solve this issue? Matthias, I am easily reachable (pdr@google.com, pdr on irc/freenode/#webkit) and respond quickly. There's really no reason to email my personal addresses :P (In reply to comment #2) > Thank you for your support so far. How long will it approximately take to solve this issue? We generally don't comment on this sort of question because it's difficult to honor. This bug is correctly triaged as P2, meaning P1 and P0 bugs are higher priority. Fixing this is important to both of us, but there have been higher-priority bugs and features this week. OK: http://commondatastorage.googleapis.com/chromium-browser-continuous/index.html?path=Win/163537/ FAILED: http://commondatastorage.googleapis.com/chromium-browser-continuous/index.html?path=Win/163549/ TEST https://bug-111402-attachments.webkit.org/attachment.cgi?id=191390 (2012-10-23) +1 for getting this fixed soon... another +1, this is very common choice 'none' for preserveAspectRatio and used extensively in many apps Had heard reports this was fixed in Safari 7, but it's not, it's still broken. This may be the patch to merge from Blink: https://chromiumcodereview.appspot.com/14964004 Created attachment 223062 [details] Patch Implement preserveAspectRatio=none for SVG images. Blink merge: https://chromiumcodereview.appspot.com/14964004 Comment on attachment 223062 [details]
Patch
Looks good to me! Thank you for merging this.
I've R+'ed this but could you please wait 24hrs to give Simon/Timothy/[other WebKit image experts] a chance to look at this?
(In reply to comment #10) > (From update of attachment 223062 [details]) > Looks good to me! Thank you for merging this. > > I've R+'ed this but could you please wait 24hrs to give Simon/Timothy/[other WebKit image experts] a chance to look at this? Sure, I will wait for their feedback. Thanks for the review! Comment on attachment 223062 [details]
Patch
LGTM
Comment on attachment 223062 [details] Patch Clearing flags on attachment: 223062 Committed r163453: <http://trac.webkit.org/changeset/163453> All reviewed patches have been landed. Closing bug. My sincere gratitude to pdr and all for fixing this in such a timely manner. I look forward to testing it out in Safari 7 |