Bug 111390

Summary:

[chromium] |m_gestureScrollOnImplThread| is not reset to false following the end of a fling on the fast path

Product:

WebKit

Reporter:

Terry Anderson <tdanderson>

Component:

UI Events

Assignee:

Terry Anderson <tdanderson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aelias, jamesr, rjkroege, webkit.review.bot, wjmaclean

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP, not for review	none
WIP, not for review	none
Patch	none
Patch for landing after compile issue fixed	none

Terry Anderson

Reported 2013-03-04 18:13:36 PST

See https://code.google.com/p/chromium/issues/detail?id=180046 for instructions on reproducing the issue. The member |m_gestureScrollOnImplThread| is not set to false after a fling gesture on the fast path because no GestureScrollEnd is sent after a fling (this is the only place outside of the WHCHI constructor where the member is set to false). As a result, GestureScrollUpdate events belonging to a non-fling gesture scroll that takes place immediately after the fling are always handled on the fast path, even in cases where the slow path should be handling these GestureScrollUpdate events.

Attachments
WIP, not for review (1.58 KB, patch) 2013-03-04 18:15 PST, Terry Anderson	no flags	Details Formatted Diff Diff
WIP, not for review (1.52 KB, patch) 2013-03-05 11:50 PST, Terry Anderson	no flags	Details Formatted Diff Diff
Patch (6.55 KB, patch) 2013-03-05 15:03 PST, Terry Anderson	no flags	Details Formatted Diff Diff
Patch for landing after compile issue fixed (6.66 KB, patch) 2013-03-06 13:50 PST, Terry Anderson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Terry Anderson

Comment 1 2013-03-04 18:15:26 PST

Created attachment 191370 [details] WIP, not for review

Terry Anderson

Comment 2 2013-03-05 11:50:51 PST

Created attachment 191527 [details] WIP, not for review

Terry Anderson

Comment 3 2013-03-05 15:03:01 PST

Created attachment 191575 [details] Patch

WebKit Review Bot

Comment 4 2013-03-06 12:57:46 PST

Comment on attachment 191575 [details] Patch Rejecting attachment 191575 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-02', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: ::MatchAndExplainImpl(testing::internal::false_type, const Class&, testing::MatchResultListener*) const [with Class = WebKit::WebSize, FieldType = int] ../../Source/WebKit/chromium/testing/gmock/include/gmock/gmock-matchers.h:1783: note: bool testing::internal::FieldMatcher<Class, FieldType>::MatchAndExplainImpl(testing::internal::true_type, const Class*, testing::MatchResultListener*) const [with Class = WebKit::WebSize, FieldType = int] ninja: build stopped: subcommand failed. Full output: http://webkit-commit-queue.appspot.com/results/17056117

Terry Anderson

Comment 5 2013-03-06 13:50:45 PST

Created attachment 191826 [details] Patch for landing after compile issue fixed

WebKit Review Bot

Comment 6 2013-03-06 14:26:30 PST

Comment on attachment 191826 [details] Patch for landing after compile issue fixed Clearing flags on attachment: 191826 Committed r144980: <http://trac.webkit.org/changeset/144980>

WebKit Review Bot

Comment 7 2013-03-06 14:26:33 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.