Bug 111387 – Use new assertion API for process suppression on Mac

• Component: WebKit2
• Status: RESOLVED FIXED

[Kiran Muppala]

Use new [NSProcessInfo beginSuspensionOfSystemBehaviors:] API to control process suppression on Mac in place of the current WKNSProcessInfoProcessAssertionWithTypes() SPI.

[Kiran Muppala]

<rdar://problem/13145081>

[Kiran Muppala]

Created attachment 191369 [details]
Patch: not ready for commit

[Kiran Muppala]

Created attachment 191374 [details]
Patch

[Kiran Muppala]

(In reply to comment #3)
> Created an attachment (id=191374) [details]
> Patch

Made a slight correction to the ChangeLog.  No source changes.

[Alexey Proskuryakov]

Comment on attachment 191374 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191374&action=review

> WebKitLibraries/WebKitSystemInterface.h:501
> +extern const NSSystemBehaviors WKProcessSuppressionSystemBehaviors;

I don't think that this should go to WebKitSystemInterface.h. We can declare the symbol anywhere, and ChildProcessMac.mm seems like the right place for that.

[Alexey Proskuryakov]

Comment on attachment 191374 [details]
Patch

The patch name says "not ready for commit", but presumably it's ready for review.

[Kiran Muppala]

(In reply to comment #5)
> (From update of attachment 191374 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=191374&action=review
> 
> > WebKitLibraries/WebKitSystemInterface.h:501
> > +extern const NSSystemBehaviors WKProcessSuppressionSystemBehaviors;
> 
> I don't think that this should go to WebKitSystemInterface.h. We can declare the symbol anywhere, and ChildProcessMac.mm seems like the right place for that.

Ah, the catch is that the symbol is actually computed in WebKitSystemInterface.m, not a simple wrapper for a underlying SPI symbol.  So, I thought it made sense to put it there.  But, as you said, the symbol does belong in ChildProcessMac.mm and can be moved there when the API becomes is public.

[Kiran Muppala]

(In reply to comment #6)
> (From update of attachment 191374 [details])
> The patch name says "not ready for commit", but presumably it's ready for review.

Yes, I wanted it to be reviewed but not cq+'d because it needs a WebKitSystemInterface part to be committed before that.  Thanks for the review.

[WebKit Review Bot]

Comment on attachment 191374 [details]
Patch

Clearing flags on attachment: 191374

Committed r144832: <http://trac.webkit.org/changeset/144832>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.