Bug 111386

Summary: [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, dglazkov, enne, fishd, junov, senorblanco, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch webkit.review.bot: commit-queue-

Description James Robinson 2013-03-04 17:38:48 PST
[chromium] Move check for threaded compositing from WebCompositorSupport to Platform
Comment 1 James Robinson 2013-03-04 17:44:26 PST
Created attachment 191363 [details]
Patch
Comment 2 James Robinson 2013-03-04 17:44:58 PST
Comment on attachment 191363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191363&action=review

> Tools/DumpRenderTree/chromium/TestShell.cpp:148
> +#if WEBKIT_SUPPORT_HAS_SET_THREADING_COMPOSITING_ENABLED

Throwing this in so this patch compiles before the chromium side lands+rolls, but the tests won't do the right thing until that happens so I won't land with this guard.
Comment 3 WebKit Review Bot 2013-03-04 17:45:47 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2013-03-04 17:46:02 PST
Attachment 191363 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platform/chromium/public/Platform.h', u'Source/Platform/chromium/public/WebCompositorSupport.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp', u'Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.h', u'Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp', u'Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp', u'Source/WebKit/chromium/ChangeLog', u'Source/WebKit/chromium/src/WebViewImpl.cpp', u'Source/WebKit/chromium/tests/Canvas2DLayerBridgeTest.cpp', u'Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp', u'Tools/ChangeLog', u'Tools/DumpRenderTree/chromium/TestShell.cpp']" exit_code: 1
Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp:99:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Adrienne Walker 2013-03-04 18:07:26 PST
Comment on attachment 191363 [details]
Patch

R=me.
Comment 6 James Robinson 2013-03-05 11:05:12 PST
Created attachment 191513 [details]
Patch
Comment 7 WebKit Review Bot 2013-03-05 11:13:12 PST
Comment on attachment 191513 [details]
Patch

Rejecting attachment 191513 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 191513, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
8.
2 out of 4 hunks FAILED -- saving rejects to file Source/WebKit/chromium/src/WebViewImpl.cpp.rej
patching file Source/WebKit/chromium/tests/Canvas2DLayerBridgeTest.cpp
patching file Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/DumpRenderTree/chromium/TestShell.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://webkit-commit-queue.appspot.com/results/16994104
Comment 8 James Robinson 2013-03-05 15:17:19 PST
Committed r144827: <http://trac.webkit.org/changeset/144827>