Summary: | [New Multicolumn] Autogenerate regions for columns | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | eric, esprehn+autocc, ojan.autocc, WebkitBugTracker, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dave Hyatt
2013-03-04 14:05:30 PST
Created attachment 191308 [details]
Patch
Comment on attachment 191308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191308&action=review > Source/WebCore/ChangeLog:137 > + Don't ever invalidate regions in response to our size changing during layout. Since I guess this refers to regions that are RenderRegionSet only. > Source/WebCore/rendering/RenderMultiColumnBlock.cpp:116 > } Is the comment above about "always putting the flow thread at the end" still valid with the new implementation? (In reply to comment #2) > (From update of attachment 191308 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=191308&action=review > > > Source/WebCore/ChangeLog:137 > > + Don't ever invalidate regions in response to our size changing during layout. Since > > I guess this refers to regions that are RenderRegionSet only. > Yeah, I'll change that to "region sets". > > Source/WebCore/rendering/RenderMultiColumnBlock.cpp:116 > > } > > Is the comment above about "always putting the flow thread at the end" still valid with the new implementation? It's not. Will remove. |