Bug 111352

Summary: Small BlobResourceHandle cleanup
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
webkit.review.bot: commit-queue-
fix chromium fork none

Alexey Proskuryakov
Reported 2013-03-04 11:58:57 PST
Just a few touches.
Attachments
proposed patch (9.39 KB, patch)
2013-03-04 12:01 PST, Alexey Proskuryakov 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
fix chromium fork (9.89 KB, patch)
2013-03-04 12:41 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-03-04 12:01:18 PST
Created attachment 191284 [details] proposed patch
WebKit Review Bot
Comment 2 2013-03-04 12:04:50 PST
Attachment 191284 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.h', u'Source/WebCore/platform/network/BlobResourceHandle.cpp', u'Source/WebCore/platform/network/BlobResourceHandle.h', u'Source/WebCore/platform/network/FormData.cpp', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceHandle.h']" exit_code: 1 Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "response" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 3 2013-03-04 12:30:37 PST
Comment on attachment 191284 [details] proposed patch Attachment 191284 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16964051
WebKit Review Bot
Comment 4 2013-03-04 12:36:45 PST
Comment on attachment 191284 [details] proposed patch Attachment 191284 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16851465
Alexey Proskuryakov
Comment 5 2013-03-04 12:41:14 PST
Created attachment 191293 [details] fix chromium fork
WebKit Review Bot
Comment 6 2013-03-04 12:45:09 PST
Attachment 191293 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/BlobRegistryImpl.cpp', u'Source/WebCore/platform/network/BlobRegistryImpl.h', u'Source/WebCore/platform/network/BlobResourceHandle.cpp', u'Source/WebCore/platform/network/BlobResourceHandle.h', u'Source/WebCore/platform/network/FormData.cpp', u'Source/WebCore/platform/network/ResourceHandle.cpp', u'Source/WebCore/platform/network/ResourceHandle.h', u'Source/WebCore/platform/network/chromium/ResourceHandle.cpp']" exit_code: 1 Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "request" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "error" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/network/BlobResourceHandle.h:55: The parameter name "response" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 7 2013-03-04 14:07:58 PST
Comment on attachment 191293 [details] fix chromium fork Clearing flags on attachment: 191293 Committed r144671: <http://trac.webkit.org/changeset/144671>
WebKit Review Bot
Comment 8 2013-03-04 14:08:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.