Bug 111345

Summary: Web Inspector: [refactoring] set frame identifiers in timeline records early, do not keep them in event stack
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, buildbot, dglazkov, keishi, loislo, peter+ews, pfeldman, pmuellr, rego+ews, rniwa, vsevik, web-inspector-bugs, webkit-ews, webkit.review.bot, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 111344    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Description Andrey Kosyakov 2013-03-04 10:22:24 PST 
We normally have frame identifiers in begin events and can set them early, there's no need to keep them in event stack.
Comment 1 Andrey Kosyakov 2013-03-04 10:25:59 PST 
Created attachment 191268 [details]
Patch
Comment 2 Early Warning System Bot 2013-03-04 10:40:38 PST 
Comment on attachment 191268 [details]
Patch

Attachment 191268 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16953030
Comment 3 Early Warning System Bot 2013-03-04 10:41:44 PST 
Comment on attachment 191268 [details]
Patch

Attachment 191268 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16970010
Comment 4 WebKit Review Bot 2013-03-04 10:43:43 PST 
Comment on attachment 191268 [details]
Patch

Attachment 191268 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16953034
Comment 5 WebKit Review Bot 2013-03-04 10:52:41 PST 
Comment on attachment 191268 [details]
Patch

Attachment 191268 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16953038
Comment 6 Build Bot 2013-03-04 11:12:43 PST 
Comment on attachment 191268 [details]
Patch

Attachment 191268 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/16969027
Comment 7 Build Bot 2013-03-04 11:21:33 PST 
Comment on attachment 191268 [details]
Patch

Attachment 191268 [details] did not pass mac-ews (mac):
Output: http://webkit-commit-queue.appspot.com/results/16932036
Comment 8 EFL EWS Bot 2013-03-04 17:56:45 PST 
Comment on attachment 191268 [details]
Patch

Attachment 191268 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/16913463
Comment 9 Peter Beverloo (cr-android ews) 2013-03-04 18:33:19 PST 
Comment on attachment 191268 [details]
Patch

Attachment 191268 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/16984007
Comment 10 Andrey Kosyakov 2013-03-05 03:03:18 PST 
Created attachment 191451 [details]
Patch
Comment 11 Andrey Kosyakov 2013-03-05 04:27:20 PST 
Committed r144749: <http://trac.webkit.org/changeset/144749>