Bug 111345

Summary: Web Inspector: [refactoring] set frame identifiers in timeline records early, do not keep them in event stack
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, buildbot, dglazkov, keishi, loislo, peter+ews, pfeldman, pmuellr, rego+ews, rniwa, vsevik, web-inspector-bugs, webkit-ews, webkit.review.bot, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 111344    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch pfeldman: review+

Andrey Kosyakov
Reported 2013-03-04 10:22:24 PST
We normally have frame identifiers in begin events and can set them early, there's no need to keep them in event stack.
Attachments
Patch (9.05 KB, patch)
2013-03-04 10:25 PST, Andrey Kosyakov 		no flags
DetailsFormatted DiffDiff
Patch (9.00 KB, patch)
2013-03-05 03:03 PST, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2013-03-04 10:25:59 PST
Created attachment 191268 [details] Patch
Early Warning System Bot
Comment 2 2013-03-04 10:40:38 PST
Comment on attachment 191268 [details] Patch Attachment 191268 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16953030
Early Warning System Bot
Comment 3 2013-03-04 10:41:44 PST
Comment on attachment 191268 [details] Patch Attachment 191268 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16970010
WebKit Review Bot
Comment 4 2013-03-04 10:43:43 PST
Comment on attachment 191268 [details] Patch Attachment 191268 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16953034
WebKit Review Bot
Comment 5 2013-03-04 10:52:41 PST
Comment on attachment 191268 [details] Patch Attachment 191268 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16953038
Build Bot
Comment 6 2013-03-04 11:12:43 PST
Comment on attachment 191268 [details] Patch Attachment 191268 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16969027
Build Bot
Comment 7 2013-03-04 11:21:33 PST
Comment on attachment 191268 [details] Patch Attachment 191268 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16932036
EFL EWS Bot
Comment 8 2013-03-04 17:56:45 PST
Comment on attachment 191268 [details] Patch Attachment 191268 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16913463
Peter Beverloo (cr-android ews)
Comment 9 2013-03-04 18:33:19 PST
Comment on attachment 191268 [details] Patch Attachment 191268 [details] did not pass cr-android-ews (chromium-android): Output: http://webkit-commit-queue.appspot.com/results/16984007
Andrey Kosyakov
Comment 10 2013-03-05 03:03:18 PST
Created attachment 191451 [details] Patch
Andrey Kosyakov
Comment 11 2013-03-05 04:27:20 PST
Committed r144749: <http://trac.webkit.org/changeset/144749>
Note You need to log in before you can comment on or make changes to this bug.