Bug 111337

Summary: Web Inspector: Add a renderer process memory size test.
Product: WebKit Reporter: Alexei Filippov <alph>
Component: Web Inspector (Deprecated)Assignee: Alexei Filippov <alph>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Alexei Filippov 2013-03-04 09:02:10 PST 
Add a renderer process memory size test.
Comment 1 Alexei Filippov 2013-03-04 09:05:15 PST 
Created attachment 191256 [details]
Patch
Comment 2 Yury Semikhatsky 2013-03-05 04:06:29 PST 
Comment on attachment 191256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191256&action=review

> Source/WebKit/chromium/src/js/Tests.js:333
> +        checkFuzzyValue(memoryBlock.size, 8000 * KB, 0.5);

We should allow for a broader range otherwise it is bound to be flaky. I think it would be enough to check that it is >1Mb and < 1.5Gb or something.
Comment 3 Alexei Filippov 2013-03-05 04:23:21 PST 
Comment on attachment 191256 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191256&action=review

>> Source/WebKit/chromium/src/js/Tests.js:333
>> +        checkFuzzyValue(memoryBlock.size, 8000 * KB, 0.5);
> 
> We should allow for a broader range otherwise it is bound to be flaky. I think it would be enough to check that it is >1Mb and < 1.5Gb or something.

1.5GB??? For a fresh renderer process??? Ok!
Comment 4 Alexei Filippov 2013-03-05 04:23:43 PST 
Created attachment 191464 [details]
Patch
Comment 5 WebKit Review Bot 2013-03-05 06:08:31 PST 
Comment on attachment 191464 [details]
Patch

Clearing flags on attachment: 191464

Committed r144755: <http://trac.webkit.org/changeset/144755>
Comment 6 WebKit Review Bot 2013-03-05 06:08:35 PST 
All reviewed patches have been landed.  Closing bug.