Bug 111332

Summary: [CSS Regions] Region's float parent doesn't size according to region size but to content node size
Product: WebKit Reporter: Mihai Balan <mibalan>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, mihnea, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Ref-test highlighting the problem
none
Patch
none
Patch for landing none

Description Mihai Balan 2013-03-04 08:17:24 PST
Created attachment 191252 [details]
Ref-test highlighting the problem

In absence of CSS Regions, floats determine their width according to the width of their children, as per the spec.
However, when a child of a float is a region, the float will use the width of the *content flowed in the region* as their width, effectively ignoring the width of the region itself.

E.g. in the attached test case, you should see a yellow circle with a black border with a 90 degrees slice from it being black (provided you have the Ahem font installed on your machine). This circle should be entirely contained in a green rectangle. However, right now the green rectangle is as wide as the black slice (just half of the circle wide).
Comment 1 Mihnea Ovidenie 2013-04-21 10:10:29 PDT
Created attachment 198966 [details]
Patch
Comment 2 Dave Hyatt 2013-04-22 12:58:23 PDT
Comment on attachment 198966 [details]
Patch

r=me
Comment 3 Mihnea Ovidenie 2013-04-22 21:23:56 PDT
Created attachment 199145 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2013-04-22 21:51:50 PDT
Comment on attachment 199145 [details]
Patch for landing

Clearing flags on attachment: 199145

Committed r148943: <http://trac.webkit.org/changeset/148943>
Comment 5 WebKit Commit Bot 2013-04-22 21:51:52 PDT
All reviewed patches have been landed.  Closing bug.