Bug 111326

Summary: Web Inspector: Exceptions when WebInspector run in hosted mode.
Product: WebKit Reporter: Eugene Klyuchnikov <eustas>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch pfeldman: review+, webkit.review.bot: commit-queue-

Eugene Klyuchnikov
Reported 2013-03-04 07:31:16 PST
There is bug in commands code generation in InspectorBackend.js As a consequence all protocol enums have wrong names and cause exception when refererenced. Currently protocol enums are referenced only from NetworkManager.
Attachments
Patch (13.66 KB, patch)
2013-03-04 07:35 PST, Eugene Klyuchnikov 		pfeldman: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eugene Klyuchnikov
Comment 1 2013-03-04 07:35:37 PST
Created attachment 191241 [details] Patch
WebKit Review Bot
Comment 2 2013-03-04 21:58:58 PST
Comment on attachment 191241 [details] Patch Rejecting attachment 191241 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-01', 'validate-changelog', '--non-interactive', 191241, '--port=chromium-xvfb']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-commit-queue.appspot.com/results/16989082
Eugene Klyuchnikov
Comment 3 2013-03-04 22:14:40 PST
Committed r144722: <http://trac.webkit.org/changeset/144722>
Note You need to log in before you can comment on or make changes to this bug.