Bug 111313 – Web Inspector: [Elements] XSLT transformation result from the xml-stylesheet PI not rendered

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Alexander Pavlov (apavlov)]

Steps to reproduce the problem:
1. browse to xml transformed by xsl into html with dev tools closed (ex: http://www.w3schools.com/xsl/cdcatalog_with_xsl.xml)
2. open developer tools, elements pane. html dom is displayed correctly
3. refresh page

What is the expected behavior?
display refreshed, retransformed xml as html DOM in dev tools elements pane

What went wrong?
elements pane displays only one childless node 'xml-stylesheet'

Upstreaming https://code.google.com/p/chromium/issues/detail?id=179265

[Alexander Pavlov (apavlov)]

Created attachment 191452 [details]
Patch

[Vivek Galatage]

Comment on attachment 191452 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191452&action=review

> Source/WebCore/inspector/InspectorInstrumentation.h:1656
> +inline void InspectorInstrumentation::documentUpdated(Frame* frame, Document* document)

A general question: When to use FAST_RETURN_IF_NO_FRONTENDS as I see there are different versions of implementations of the instrumentation methods of which some use this macro while others don't? Any rule of thumb is there with respect to usage of the macro?

[Alexander Pavlov (apavlov)]

Created attachment 191989 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 191989 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191989&action=review

> Source/WebCore/dom/Document.cpp:4246
> +    InspectorInstrumentation::documentUpdated(ownerFrame, ownerFrame->document());

I don't think you need to pass document here.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1686
> +    DocumentLoader* loader = frame->loader()->documentLoader();

I don't think this is needed.

> Source/WebCore/inspector/InspectorInstrumentation.h:1656
> +#if ENABLE(INSPECTOR)

Please add FAST_RETURN_IF_NO_FRONTENDS check here.

[Alexander Pavlov (apavlov)]

Created attachment 192001 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 192001 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=192001&action=review

> Source/WebCore/inspector/InspectorDOMAgent.cpp:54
> +#include "DocumentLoader.h"

Please remove this.

[Alexander Pavlov (apavlov)]

Created attachment 192003 [details]
Patch

[Alexander Pavlov (apavlov)]

Committed r145342: <http://trac.webkit.org/changeset/145342>