Bug 111308

Summary: [v8] add isolate parameter to heap statistics calls
Product: WebKit Reporter: Dan Carney <dcarney>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, haraken, japhet, jochen, rniwa, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Dan Carney
Reported 2013-03-04 06:10:29 PST
[v8] add isolate parameter to heap statistics calls
Attachments
Patch (8.81 KB, patch)
2013-03-04 06:11 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Patch (3.83 KB, patch)
2013-03-04 06:46 PST, Dan Carney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dan Carney
Comment 1 2013-03-04 06:11:42 PST
Created attachment 191219 [details] Patch
Early Warning System Bot
Comment 2 2013-03-04 06:30:56 PST
Comment on attachment 191219 [details] Patch Attachment 191219 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16899888
Early Warning System Bot
Comment 3 2013-03-04 06:34:31 PST
Comment on attachment 191219 [details] Patch Attachment 191219 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16910636
Build Bot
Comment 4 2013-03-04 06:41:31 PST
Comment on attachment 191219 [details] Patch Attachment 191219 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16910634
jochen
Comment 5 2013-03-04 06:46:08 PST
Comment on attachment 191219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191219&action=review > Source/WebCore/inspector/InspectorMemoryAgent.cpp:207 > + ScriptGCEvent::getHeapSize(v8::Isolate::GetCurrent(), info); everything from here on is WebCore and can't depend directly on v8::
Dan Carney
Comment 6 2013-03-04 06:46:56 PST
Created attachment 191230 [details] Patch
jochen
Comment 7 2013-03-04 06:49:00 PST
Comment on attachment 191230 [details] Patch ok
WebKit Review Bot
Comment 8 2013-03-04 13:04:09 PST
Comment on attachment 191230 [details] Patch Clearing flags on attachment: 191230 Committed r144661: <http://trac.webkit.org/changeset/144661>
WebKit Review Bot
Comment 9 2013-03-04 13:04:13 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.