Bug 111292

Summary: Web Inspector: touchmove not emulated inside iframe
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch vsevik: review+

Description Alexander Pavlov (apavlov) 2013-03-04 01:04:03 PST
Steps to reproduce the problem:
1. Turn "Emulate touch events" on from devtools / cog / overrides.
2. Go to http://codepen.io/jussi-kalliokoski/pen/hLBID .
3. Hold mouse down over the element containing the text.
4. Move the mouse while holding the mouse button down.

What is the expected behavior?
The console should log that the touchmove event occurred.

What went wrong?
Only touchstart and touchend get logged.

Upstreaming https://code.google.com/p/chromium/issues/detail?id=178714
Comment 1 Alexander Pavlov (apavlov) 2013-03-04 01:11:44 PST
Created attachment 191170 [details]
Patch
Comment 2 Vsevolod Vlasov 2013-03-04 01:31:26 PST
Comment on attachment 191170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191170&action=review

> Source/WebCore/page/EventHandler.cpp:1631
> +    // FIXME: this should be moved elsewhere to also be able to dispatch touchcancel events.

Isn't this comment obsolete?

> Source/WebCore/page/EventHandler.cpp:1632
> +    bool defaultPrevented = dispatchSyntheticTouchEventIfEnabled(mouseEvent);

if (dispatchSyntheticTouchEventIfEnabled(mouseEvent))
    return true;
Comment 3 Alexander Pavlov (apavlov) 2013-03-04 01:38:47 PST
Committed r144608: <http://trac.webkit.org/changeset/144608>