Bug 111269

Summary: JSC_OBJC_API_ENABLED should be removed from FeatureDefines.h
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cmarcelo, ddkilzer, laszlo.gombos, ojan.autocc, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
1st take
buildbot: commit-queue-
fix max builds none

Mark Hahnenberg
Reported 2013-03-03 09:10:09 PST
From bug 110291: "This flag was originally added to FeatureDefines.h so that it could be used in WebCore.exp.in to determine whether or not we should be exporting certain symbols based on whether the WebKit-related portion of the JSC ObjC API was enabled, but it turned out conditionally including certain symbols didn't work when building fat binaries, so it's not even necessary any more. tl;dr: removing JSC_OBJC_API_ENABLED from FeatureDefines.h is a good idea."
Attachments
1st take (1.64 KB, patch)
2013-03-03 14:01 PST, Laszlo Gombos 		buildbot: commit-queue-
DetailsFormatted DiffDiff
fix max builds (2.83 KB, patch)
2013-03-03 17:50 PST, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2013-03-03 14:01:05 PST
Created attachment 191143 [details] 1st take
Build Bot
Comment 2 2013-03-03 14:59:53 PST
Comment on attachment 191143 [details] 1st take Attachment 191143 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-commit-queue.appspot.com/results/16862955
Build Bot
Comment 3 2013-03-03 15:26:33 PST
Comment on attachment 191143 [details] 1st take Attachment 191143 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16911184
Build Bot
Comment 4 2013-03-03 16:25:23 PST
Comment on attachment 191143 [details] 1st take Attachment 191143 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/16910317
Laszlo Gombos
Comment 5 2013-03-03 17:50:33 PST
Created attachment 191157 [details] fix max builds
Laszlo Gombos
Comment 6 2013-03-04 06:51:31 PST
(In reply to comment #5) > Created an attachment (id=191157) [details] > fix max builds I mean mac builds.
Mark Hahnenberg
Comment 7 2013-03-04 12:42:23 PST
Comment on attachment 191157 [details] fix max builds r=me. Thanks for tackling this patch!
WebKit Review Bot
Comment 8 2013-03-04 13:13:34 PST
Comment on attachment 191157 [details] fix max builds Clearing flags on attachment: 191157 Committed r144662: <http://trac.webkit.org/changeset/144662>
WebKit Review Bot
Comment 9 2013-03-04 13:13:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.