Summary: | Box-shadow displayed improperly with border-radius. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Harmageddon <harmageddon95> | ||||||||
Component: | CSS | Assignee: | Takashi Sakamoto <tasak> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | simon.fraser, tasak, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows 7 | ||||||||||
URL: | http://www.harmageddon.broesel.org/tsghntt/ | ||||||||||
Attachments: |
|
Description
Harmageddon
2013-03-02 13:31:46 PST
Created attachment 191431 [details]
Patch
Attachment 191431 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/borders/border-radius-with-box-shadow-01-expected.txt', u'LayoutTests/fast/borders/border-radius-with-box-shadow-01.html', u'LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/RoundedRect.cpp']" exit_code: 1
LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 191431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191431&action=review > LayoutTests/fast/borders/border-radius-with-box-shadow-01.html:10 > +#target { > + width: 100px; > + height: 18px; > + box-shadow: 0 0 5px -1px #777777; > + border-radius: 0 0 19px 19px; > +} Please make this much bigger so the bug/fix is more obvious. Created attachment 191919 [details]
Patch
Comment on attachment 191431 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191431&action=review Thank you for reviewing. >> LayoutTests/fast/borders/border-radius-with-box-shadow-01.html:10 >> +} > > Please make this much bigger so the bug/fix is more obvious. Sure. Done. Attachment 191919 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/borders/border-radius-with-box-shadow-01-expected.txt', u'LayoutTests/fast/borders/border-radius-with-box-shadow-01.html', u'LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/RoundedRect.cpp']" exit_code: 1
LayoutTests/platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png:0: Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png"). [image/png] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 191919 [details] Patch Clearing flags on attachment: 191919 Committed r145044: <http://trac.webkit.org/changeset/145044> All reviewed patches have been landed. Closing bug. |