Bug 11124

Summary: REGRESSION (r14297): No drag image for partially-selected complex text
Product: WebKit Reporter: mitz
Component: TextAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Major CC: hyatt
Priority: P1 Keywords: EasyFix, InRadar, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Pixel test
none
Patch darin: review+

Description mitz 2006-10-02 08:43:46 PDT
To reproduce, choose Debug > Use ATSU For All Text, select a single word from the middle of a sentence on this page, and then try to drag the selected text. Although drag and drop behaves as expected, there's no drag image, and with a debug build you get this in the console:
=================
ERROR: ATSUDrawText() failed(-8792)
(WebCore/platform/mac/FontMac.mm:505 drawComplexText)
=================

This is a regression from r14297 (fix for bug 8845).
Comment 1 mitz 2006-10-04 01:41:11 PDT
Created attachment 10889 [details]
Pixel test

This invokes the same code that is used for the drag image, so it can be used for an automated pixel test.
Comment 2 mitz 2006-11-02 16:16:45 PST
This is very bad but should be easy to fix.
Comment 3 Stephanie Lewis 2006-11-08 14:31:42 PST
radar 4826775
Comment 4 mitz 2006-12-26 11:30:08 PST
Created attachment 12038 [details]
Patch
Comment 5 Darin Adler 2006-12-27 22:03:40 PST
Comment on attachment 12038 [details]
Patch

r=me
Comment 6 Sam Weinig 2006-12-28 12:09:19 PST
Landed in r18457.