Bug 111237

Summary:

Remove a number of fields from WebURLResponse

Product:

WebKit

Reporter:

Ryan Hamilton <rch>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

ahmad.saleem792, mkwst, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Remove a number of fields from WebURLResponse. A Chromium CL	fishd: review+, webkit.review.bot: commit-queue-

Ryan Hamilton

Reported 2013-03-01 16:53:59 PST

Remove a number of fields from WebURLResponse

Attachments
Patch (9.84 KB, patch) 2013-03-01 17:03 PST, Ryan Hamilton	no flags	Details Formatted Diff Diff
Patch (9.83 KB, patch) 2013-03-11 09:42 PDT, Ryan Hamilton	no flags	Details Formatted Diff Diff
Remove a number of fields from WebURLResponse. A Chromium CL (8.24 KB, patch) 2013-03-11 09:44 PDT, Ryan Hamilton	fishd: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ryan Hamilton

Comment 1 2013-03-01 17:03:10 PST

Created attachment 191074 [details] Patch

Darin Fisher (:fishd, Google)

Comment 2 2013-03-03 21:40:53 PST

Comment on attachment 191074 [details] Patch Fantastic! Note to reviewers / committers: This should only be committed after https://codereview.chromium.org/12381054/

Ryan Hamilton

Comment 3 2013-03-11 09:42:46 PDT

Created attachment 192486 [details] Patch

Ryan Hamilton

Comment 4 2013-03-11 09:44:58 PDT

Created attachment 192487 [details] Remove a number of fields from WebURLResponse. A Chromium CL

Ryan Hamilton

Comment 5 2013-03-11 09:45:33 PDT

I think I did something wrong with web-kit upload in that it appears to have lost the r+ bit which was added initially :<

WebKit Review Bot

Comment 6 2013-03-12 11:11:31 PDT

Comment on attachment 192487 [details] Remove a number of fields from WebURLResponse. A Chromium CL Rejecting attachment 192487 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 192487, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13882 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 54>At revision 13882. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://webkit-commit-queue.appspot.com/results/17192059

Mike West

Comment 7 2013-03-16 04:40:38 PDT

(In reply to comment #6) > (From update of attachment 192487 [details]) > Rejecting attachment 192487 [details] from commit-queue. You'll need to add a ChangeLog file before landing this. You can generate a stub via `./Tools/Scripts/prepare-ChangeLog --bug 111237`.

Ahmad Saleem

Comment 8 2024-03-09 18:47:33 PST

Changes were in Chromium port as can be seen from attached patch.

Note You need to log in before you can comment on or make changes to this bug.