Bug 111217 – REGRESSION(r143727): Clicking / selecting inside an <embed> is broken

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Julien Chaffraix]

Created attachment 191028 [details]
Zip of the test case as it requires 2 files

r143727 made us regress the hit testing on embed (haven't tried plugins too). For some reason, we still update the cursor as we move the mouse but the click seems to be stopped at the embed (as shown if you try using the web-inspector).

[Alexey Proskuryakov]

What is the next step here? <http://trac.webkit.org/changeset/143727> sounds like a non-essential improvement per ChangeLog, would rolling it out be appropriate?

[Julien Chaffraix]

Got another reproduction and it turns out that hit-testing through <object> is also broken: http://jsfiddle.net/2RyWt/2/

> What is the next step here? <http://trac.webkit.org/changeset/143727> sounds like a non-essential improvement per ChangeLog, would rolling it out be appropriate?

I am in favor of rolling out unless something is done within 1 or 2 days. I don't have the bandwidth to investigate this bug but I will be happy to handle the revert. The change was supposed to be a refactoring but it turns out to be major hit testing regression.

[Allan Sandfeld Jensen]

Created attachment 191765 [details]
Patch

[Early Warning System Bot]

Comment on attachment 191765 [details]
Patch

Attachment 191765 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/16985223

[Build Bot]

Comment on attachment 191765 [details]
Patch

Attachment 191765 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17027081

[WebKit Review Bot]

Comment on attachment 191765 [details]
Patch

Attachment 191765 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/16985224

[Peter Beverloo (cr-android ews)]

Comment on attachment 191765 [details]
Patch

Attachment 191765 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17072114

[Allan Sandfeld Jensen]

Created attachment 191770 [details]
Patch

Missed file

[Early Warning System Bot]

Comment on attachment 191770 [details]
Patch

Attachment 191770 [details] did not pass qt-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17105001

[WebKit Review Bot]

Comment on attachment 191770 [details]
Patch

Attachment 191770 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17079151

[Build Bot]

Comment on attachment 191770 [details]
Patch

Attachment 191770 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17082237

[EFL EWS Bot]

Comment on attachment 191770 [details]
Patch

Attachment 191770 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17049373

[WebKit Review Bot]

Comment on attachment 191770 [details]
Patch

Attachment 191770 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://webkit-commit-queue.appspot.com/results/17027093

[Peter Beverloo (cr-android ews)]

Comment on attachment 191770 [details]
Patch

Attachment 191770 [details] did not pass cr-android-ews (chromium-android):
Output: http://webkit-commit-queue.appspot.com/results/17072126

[Allan Sandfeld Jensen]

Comment on attachment 191770 [details]
Patch

Needs a test, and be uploaded correctly.

[Early Warning System Bot]

Comment on attachment 191770 [details]
Patch

Attachment 191770 [details] did not pass qt-wk2-ews (qt):
Output: http://webkit-commit-queue.appspot.com/results/17027106

[Antonio Gomes]

It should be at least linked to the offending commit.

[Allan Sandfeld Jensen]

Created attachment 191957 [details]
Patch

[Julien Chaffraix]

Comment on attachment 191957 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=191957&action=review

> LayoutTests/fast/dom/nodesFromRect/nodesFromRect-embedded-frame-content.html:34
> +            <embed id="iframe1" src="resources/child-frame.html"></embed>

There was another test that was linked to that used <object>: http://jsfiddle.net/2RyWt/2/

I think it's worthwhile to add this case too.

[Allan Sandfeld Jensen]

Committed r145098: <http://trac.webkit.org/changeset/145098>