Bug 111208

Summary: CSP: Throw a warning when a '*-report-only' header doesn't contain a 'report-uri' directive.
Product: WebKit Reporter: Mike West <mkwst>
Component: WebCore Misc.Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, justashar, mkwst+watchlist, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 85558    
Attachments:
Description Flags
Patch
none
Patch none

Mike West
Reported 2013-03-01 12:33:09 PST
Apparently people set report-only headers without a report URI, as evidenced by https://twitter.com/soaj1664ashar/status/307450782704365569. We should help them understand that they've basically created an expensive no-op machine.
Attachments
Patch (7.06 KB, patch)
2013-03-02 01:16 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Patch (6.76 KB, patch)
2013-03-02 01:17 PST, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2013-03-02 01:16:35 PST
Created attachment 191100 [details] Patch
Mike West
Comment 2 2013-03-02 01:17:41 PST
Created attachment 191101 [details] Patch
Adam Barth
Comment 3 2013-03-02 23:09:33 PST
Comment on attachment 191101 [details] Patch Good idea.
WebKit Review Bot
Comment 4 2013-03-02 23:42:09 PST
Comment on attachment 191101 [details] Patch Rejecting attachment 191101 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 191101, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue Last 500 characters of output: fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource fatal: read error: Connection reset by peer Died at Tools/Scripts/update-webkit line 151. Full output: http://webkit-commit-queue.appspot.com/results/16882568
Mike West
Comment 5 2013-03-03 01:12:14 PST
Comment on attachment 191101 [details] Patch Let's try the CQ again. It looks healthier.
WebKit Review Bot
Comment 6 2013-03-03 01:30:52 PST
Comment on attachment 191101 [details] Patch Clearing flags on attachment: 191101 Committed r144566: <http://trac.webkit.org/changeset/144566>
WebKit Review Bot
Comment 7 2013-03-03 01:30:55 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.