Summary: | Web Inspector: Move sidebar-specific styles to a separate file | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vladislav Kaznacheev <kaznacheev> | ||||||||
Component: | Web Inspector (Deprecated) | Assignee: | Vladislav Kaznacheev <kaznacheev> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | apavlov, buildbot, keishi, loislo, pfeldman, pmuellr, rniwa, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Vladislav Kaznacheev
2013-03-01 05:57:47 PST
Created attachment 190952 [details]
Patch
Comment on attachment 190952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190952&action=review > Source/WebCore/inspector/front-end/sidebarPane.css:63 > +.sidebar-tabbed-pane .tabbed-pane-header { SidebarPane does not know anything about tabbed-pane-header > Source/WebCore/inspector/front-end/sidebarPane.css:131 > +.sidebar-pane-toolbar > select { All of these are elementsPanel specific > Source/WebCore/inspector/front-end/sidebarPane.css:287 > +.event-listener-breakpoints .event-category { These are elements panel specific. Created attachment 191244 [details]
Patch
Comment on attachment 190952 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190952&action=review >> Source/WebCore/inspector/front-end/sidebarPane.css:63 >> +.sidebar-tabbed-pane .tabbed-pane-header { > > SidebarPane does not know anything about tabbed-pane-header SidebarPanes does not but SidebarTabbedPane does. >> Source/WebCore/inspector/front-end/sidebarPane.css:131 >> +.sidebar-pane-toolbar > select { > > All of these are elementsPanel specific Moved to elementsPanel.css >> Source/WebCore/inspector/front-end/sidebarPane.css:287 >> +.event-listener-breakpoints .event-category { > > These are elements panel specific. Moved to elementsPanel.css Comment on attachment 191244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191244&action=review > Source/WebCore/inspector/front-end/elementsPanel.css:534 > +.sidebar-pane-toolbar > select:hover { I would imagine that this file only gets styles with ".elements-" prefix otherwise, you are at risk of breaking stuff on other panels (styles are unloaded when you switch off the panel). > Source/WebCore/inspector/front-end/scriptsPanel.css:312 > +.sidebar-pane > .body .breakpoint-condition { Like these ones are ok - they all mention breakpoint... > Source/WebCore/inspector/front-end/scriptsPanel.css:328 > +ol.breakpoint-list { And what about DOM Breakpoints? They might rely upon this style. I might be that breakpoints list view might need to have its own CSS. > Source/WebCore/inspector/front-end/sidebarPane.css:73 > +.pane-title { Should we rename this to .sidebar-pane-title? Comment on attachment 191244 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=191244&action=review >> Source/WebCore/inspector/front-end/elementsPanel.css:534 >> +.sidebar-pane-toolbar > select:hover { > > I would imagine that this file only gets styles with ".elements-" prefix otherwise, you are at risk of breaking stuff on other panels (styles are unloaded when you switch off the panel). Prefixed all these rules with .panel.elements >> Source/WebCore/inspector/front-end/scriptsPanel.css:312 >> +.sidebar-pane > .body .breakpoint-condition { > > Like these ones are ok - they all mention breakpoint... Thanks, I guess. >> Source/WebCore/inspector/front-end/scriptsPanel.css:328 >> +ol.breakpoint-list { > > And what about DOM Breakpoints? They might rely upon this style. I might be that breakpoints list view might need to have its own CSS. You caught me red-handed. Created breakpointsList.css. >> Source/WebCore/inspector/front-end/sidebarPane.css:73 >> +.pane-title { > > Should we rename this to .sidebar-pane-title? Done Created attachment 191475 [details]
Patch
Comment on attachment 191475 [details] Patch Attachment 191475 [details] did not pass mac-ews (mac): Output: http://webkit-commit-queue.appspot.com/results/17015041 New failing tests: editing/selection/selection-invalid-offset.html Comment on attachment 191475 [details] Patch Clearing flags on attachment: 191475 Committed r144927: <http://trac.webkit.org/changeset/144927> All reviewed patches have been landed. Closing bug. |