Bug 11117

Summary: WebDataSource data should be moved to WebDocumentLoadState
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: WebKit Misc.Assignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
patch darin: review+

Maciej Stachowiak
Reported 2006-10-02 04:31:16 PDT
This is a necessary refactoring.
Attachments
patch (50.77 KB, patch)
2006-10-02 04:32 PDT, Maciej Stachowiak 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2006-10-02 04:32:11 PDT
Created attachment 10864 [details] patch
Darin Adler
Comment 2 2006-10-02 08:32:15 PDT
Comment on attachment 10864 [details] patch +- (void)setResponse:(NSURLResponse *)resp +{ + [response release]; + response = [resp retain]; +} Shouldn't we use the retain before release idiom here, or add an assert? + // XXX: fixme retains I think we should replace this comment with a more-coherent one or remove it. - ASSERT(!loading); + ASSERT(![loadState isLoading]); Maybe that assert should move into the loadState object? r=me
Maciej Stachowiak
Comment 3 2006-10-02 16:57:34 PDT
I addressed the first two comments but not the last - it will probably be addressed later as more code moves to WebDocumentLoadState.
Note You need to log in before you can comment on or make changes to this bug.