Bug 111169

Summary: REGRESSION(r144443): Caused 2 tests to crash by segv on Chromium Mac10.6 (Requested by toyoshim on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, toyoshim, vcarbune
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 110703    
Attachments:
Description Flags
ROLLOUT of r144443 none

Description WebKit Review Bot 2013-03-01 05:26:59 PST
http://trac.webkit.org/changeset/144443 broke the build:
Caused 2 tests to crash by segv on Chromium Mac10.6 (Requested by toyoshim on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2013-03-01 05:27:29 PST
Created attachment 190943 [details]
ROLLOUT of r144443

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 3 WebKit Review Bot 2013-03-01 05:40:53 PST
Comment on attachment 190943 [details]
ROLLOUT of r144443

Clearing flags on attachment: 190943

Committed r144447: <http://trac.webkit.org/changeset/144447>
Comment 4 WebKit Review Bot 2013-03-01 05:40:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Eric Carlson 2013-03-01 07:48:36 PST
(In reply to comment #2)
> http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/34858/steps/layout-test/logs/stdio
> 
> Here is crash log

Is fast/reflections/reflection-overflow-hidden.html the test that crashed? If so, it seems unlikely that a change to RenderTextTrackCue.cpp could cause that.
Comment 6 Victor Carbune 2013-03-01 11:00:03 PST
(In reply to comment #5)
> (In reply to comment #2)
> > http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/34858/steps/layout-test/logs/stdio
> > 
> > Here is crash log
> 
> Is fast/reflections/reflection-overflow-hidden.html the test that crashed? If so, it seems unlikely that a change to RenderTextTrackCue.cpp could cause that.

I saw that track-cue-snap-to-lines-not-set was failing and I thought that's one
of the failing tests mentioned, but looking again at the Chromium Mac10.6 it seems
like that the test is still failing anyway (weird output, though).

I think this was an unnecessary rollback.
Comment 7 Eric Carlson 2013-03-01 11:12:07 PST
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #2)
> > > http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/34858/steps/layout-test/logs/stdio
> > > 
> > > Here is crash log
> > 
> > Is fast/reflections/reflection-overflow-hidden.html the test that crashed? If so, it seems unlikely that a change to RenderTextTrackCue.cpp could cause that.
> 
> I saw that track-cue-snap-to-lines-not-set was failing and I thought that's one
> of the failing tests mentioned, but looking again at the Chromium Mac10.6 it seems
> like that the test is still failing anyway (weird output, though).
> 
> I think this was an unnecessary rollback.

I will be happy to r+ https://bugs.webkit.org/show_bug.cgi?id=110703 again if you have some time to watch the bots after it lands.
Comment 8 Victor Carbune 2013-03-01 12:06:18 PST
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > I think this was an unnecessary rollback.
> 
> I will be happy to r+ https://bugs.webkit.org/show_bug.cgi?id=110703 again if you have some time to watch the bots after it lands.

Sound good - I re-uploaded the patch and I'll watch the bots after
it lands.