Bug 111153

Summary:

[BlackBerry] New files for BlackBerry::Platform::Graphics::GraphicsContext integration

Product:

WebKit

Reporter:

Arvid Nilsson <anilsson>

Component:

WebKit BlackBerry

Assignee:

Arvid Nilsson <anilsson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, cgarcia, mifenton, rwlbuis, tonikitoo, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

73144

Attachments:

Description	Flags
Patch	none

Arvid Nilsson

Reported 2013-03-01 01:41:15 PST

See also bug #111072. Internal PR 293208

Attachments
Patch (108.67 KB, patch) 2013-03-01 10:46 PST, Arvid Nilsson	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Arvid Nilsson

Comment 1 2013-03-01 10:46:48 PST

Created attachment 190987 [details] Patch

Rob Buis

Comment 2 2013-03-01 10:51:52 PST

Comment on attachment 190987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190987&action=review LGTM. > Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp:23 > + Nit: we do the amount of spacing between licensing and includes inconsistently. I personally would not do two, not zero, but likely one empty line.

WebKit Review Bot

Comment 3 2013-03-01 11:07:59 PST

Attachment 190987 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontCustomPlatformData.h', u'Source/WebCore/platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GradientBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/ITypeUtils.h', u'Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/ImageBufferDataBlackBerry.h', u'Source/WebCore/platform/graphics/blackberry/PathBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/PatternBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/PlatformSupport.cpp', u'Source/WebCore/platform/graphics/blackberry/PlatformSupport.h', u'Source/WebCore/platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp']" exit_code: 1 Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:289: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:290: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:291: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:292: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:293: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:295: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:296: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:297: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:301: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:303: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:306: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:307: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:309: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 13 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

Arvid Nilsson

Comment 4 2013-03-04 03:03:53 PST

(In reply to comment #3) > Attachment 190987 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontCustomPlatformData.h', u'Source/WebCore/platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GradientBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/ITypeUtils.h', u'Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/ImageBufferDataBlackBerry.h', u'Source/WebCore/platform/graphics/blackberry/PathBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/PatternBlackBerry.cpp', u'Source/WebCore/platform/graphics/blackberry/PlatformSupport.cpp', u'Source/WebCore/platform/graphics/blackberry/PlatformSupport.h', u'Source/WebCore/platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp']" exit_code: 1 > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:289: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:290: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:291: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:292: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:293: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:295: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:296: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:297: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:301: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:303: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:306: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:307: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp:309: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] > Total errors found: 13 in 17 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. These are expected failures, we'll leave it as is.

Arvid Nilsson

Comment 5 2013-03-04 03:04:32 PST

(In reply to comment #2) > (From update of attachment 190987 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=190987&action=review > > LGTM. > > > Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp:23 > > + > > Nit: we do the amount of spacing between licensing and includes inconsistently. I personally would not do two, not zero, but likely one empty line. I agree, but lets get this landed and then fix it up. Thanks for the review =)

WebKit Review Bot

Comment 6 2013-03-04 03:12:00 PST

Comment on attachment 190987 [details] Patch Clearing flags on attachment: 190987 Committed r144612: <http://trac.webkit.org/changeset/144612>

WebKit Review Bot

Comment 7 2013-03-04 03:12:04 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.