Bug 111125

Summary:

Add SPI for marking a WebView as doing things on behalf of another process

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ap: review+

Description Sam Weinig 2013-02-28 15:50:25 PST

Add SPI for marking a WebView as doing things on behalf of another process

Comment 1 Sam Weinig 2013-02-28 17:20:17 PST

Created attachment 190853 [details]
Patch

Comment 2 WebKit Review Bot 2013-02-28 17:25:22 PST

Attachment 190853 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/NetworkingContext.h', u'Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp', u'Source/WebCore/platform/network/mac/ResourceHandleMac.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.h', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit/mac/WebView/WebViewData.mm', u'Source/WebKit/mac/WebView/WebViewPrivate.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.h', u'Source/WebKit2/NetworkProcess/mac/RemoteNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm']" exit_code: 1
Source/WebKit/mac/WebView/WebViewPrivate.h:638:  Missing spaces around =  [whitespace/operators] [4]
Source/WebKit/mac/WebView/WebViewPrivate.h:638:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Alexey Proskuryakov 2013-02-28 20:26:45 PST

Comment on attachment 190853 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190853&action=review

Some comments below. No r+, because I have no idea what this is about, and I think that I need to know. Is there a Radar bug?

> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:466
> +#if PLATFORM(MAC)
> +#if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090

Does iOS still define PLATFORM(MAC)? I thought it no longer did.

> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:473
> +    static const CFStringRef kCFURLConnectionSocketStreamProperties = CFSTR("kCFURLConnectionSocketStreamProperties");

Is this "static const" play still necessary with MSVC? It's certainly no good with gcc and clang.

> Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm:24
> +#import "WebViewPrivate.h"
> +#import "WebFrameInternal.h"

Include order.

> Source/WebKit/mac/WebView/WebViewData.h:209
> +    NSData *sourceApplicationAuditData;

Why is this not a RetainPtr?

Comment 4 Sam Weinig 2013-03-01 09:57:08 PST

<rdar://problem/13167973>

Comment 5 Alexey Proskuryakov 2013-03-01 10:07:18 PST

Comment on attachment 190853 [details]
Patch

r=me. Please address the above comments.

Comment 6 Sam Weinig 2013-03-01 13:34:39 PST

Committed r144495: <http://trac.webkit.org/changeset/144495>