Bug 111118

Summary:

Add FeatureObserver for marquee and reflection

Product:

WebKit

Reporter:

Julien Chaffraix <jchaffraix>

Component:

Layout and Rendering

Assignee:

Julien Chaffraix <jchaffraix>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eae, eric, esprehn+autocc, leviw, ojan.autocc, ojan, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed change.	none
Proposed change 2: Split marquee between <marquee> and overflow: -webkit-marquee.	none

Description Julien Chaffraix 2013-02-28 15:02:46 PST

These 2 features are still proprietary / prefixed and we will need to unprefix them some day.

In order to know if that's an option, we need to gather some numbers about their popularity. That's where FeatureObserver kicks in.

Comment 1 Julien Chaffraix 2013-02-28 15:28:17 PST

Created attachment 190823 [details]
Proposed change.

Comment 2 Levi Weintraub 2013-02-28 15:33:14 PST

Comment on attachment 190823 [details]
Proposed change.

Great! I'm really curious :)

Comment 3 Simon Fraser (smfr) 2013-02-28 15:33:19 PST

What are you trying to observe? <marquee> or overflow: -webkit-marquee ?

Comment 4 Julien Chaffraix 2013-02-28 15:37:12 PST

(In reply to comment #3)
> What are you trying to observe? <marquee> or overflow: -webkit-marquee ?

Both, basically whenever we create a RenderMarquee on a page. For now, I am not really concerned by what generated the marquee. If needed, we can always add more granularity.

Comment 5 Simon Fraser (smfr) 2013-02-28 15:39:00 PST

(In reply to comment #4)
> (In reply to comment #3)
> > What are you trying to observe? <marquee> or overflow: -webkit-marquee ?
> 
> Both, basically whenever we create a RenderMarquee on a page. For now, I am not really concerned by what generated the marquee. If needed, we can always add more granularity.

It's obvious that <marquee> is pretty popular (perhaps less so with the demise of Geocities).

Comment 6 Julien Chaffraix 2013-02-28 16:04:47 PST

Created attachment 190833 [details]
Proposed change 2: Split marquee between <marquee> and overflow: -webkit-marquee.

Comment 7 Levi Weintraub 2013-02-28 16:13:08 PST

Comment on attachment 190833 [details]
Proposed change 2: Split marquee between <marquee> and overflow: -webkit-marquee.

LGTM, but I'll wait for smfr.

Comment 8 WebKit Review Bot 2013-03-01 07:49:23 PST

Comment on attachment 190833 [details]
Proposed change 2: Split marquee between <marquee> and overflow: -webkit-marquee.

Clearing flags on attachment: 190833

Committed r144456: <http://trac.webkit.org/changeset/144456>

Comment 9 WebKit Review Bot 2013-03-01 07:49:27 PST

All reviewed patches have been landed.  Closing bug.