| Summary: | [CSS Regions] Regions auto-height and absolute positioning bug | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | CJ Gammon <gammon> | ||||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, mihnea, obzhirov, WebkitBugTracker | ||||||||
| Priority: | P2 | Keywords: | AdobeTracked | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 57312 | ||||||||||
| Attachments: |
|
||||||||||
I will try to fix this one - will take some time for me to catch up with css regions. Created attachment 203199 [details]
Patch
(In reply to comment #2) > Created an attachment (id=203199) [details] > Patch Thanks for the attempt. I suggest that you should write a patch for review following the guidelines from WebKit. This should include a test for the patch, a changelog in which you should explain what was the problem and how your solution fixes the problem. I will do that, I suppose I can reuse test demo attached as a basic for new layout test? (In reply to comment #4) > I will do that, I suppose I can reuse test demo attached as a basic for new layout test? Sure. Some of the layout tests in fast/regions use a script, check-layout.js, it may be a good idea to use it for this test instead of writing a ref test. Created attachment 203811 [details]
Patch
Comment on attachment 203811 [details]
Patch
r=me
Comment on attachment 203811 [details] Patch Clearing flags on attachment: 203811 Committed r151554: <http://trac.webkit.org/changeset/151554> All reviewed patches have been landed. Closing bug. |
Created attachment 190755 [details] reduced test demo of height auto error with absolute positioning when absolutely positioning a region at bottom: 0; it seems to not use the calculated height of the element when the height is auto. Instead it treats the element like it has no height for positioning. In this example I would expect the bottom of the element to be at the bottom of the screen, but as you can see it puts the top at the bottom of the screen.