Bug 111092

Summary: [CSS Regions] Regions auto-height and absolute positioning bug
Product: WebKit Reporter: CJ Gammon <gammon>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, mihnea, obzhirov, WebkitBugTracker
Priority: P2 Keywords: AdobeTracked
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
reduced test demo of height auto error with absolute positioning
none
Patch
none
Patch none

CJ Gammon
Reported 2013-02-28 10:39:32 PST
Created attachment 190755 [details] reduced test demo of height auto error with absolute positioning when absolutely positioning a region at bottom: 0; it seems to not use the calculated height of the element when the height is auto. Instead it treats the element like it has no height for positioning. In this example I would expect the bottom of the element to be at the bottom of the screen, but as you can see it puts the top at the bottom of the screen.
Attachments
reduced test demo of height auto error with absolute positioning (937 bytes, application/zip)
2013-02-28 10:39 PST, CJ Gammon 		no flags
Details
Patch (1.56 KB, patch)
2013-05-29 07:14 PDT, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Patch (3.93 KB, patch)
2013-06-05 05:38 PDT, Anton Obzhirov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anton Obzhirov
Comment 1 2013-05-23 08:34:53 PDT
I will try to fix this one - will take some time for me to catch up with css regions.
Anton Obzhirov
Comment 2 2013-05-29 07:14:06 PDT
Created attachment 203199 [details] Patch
Mihnea Ovidenie
Comment 3 2013-05-30 23:42:08 PDT
(In reply to comment #2) > Created an attachment (id=203199) [details] > Patch Thanks for the attempt. I suggest that you should write a patch for review following the guidelines from WebKit. This should include a test for the patch, a changelog in which you should explain what was the problem and how your solution fixes the problem.
Anton Obzhirov
Comment 4 2013-06-03 02:45:03 PDT
I will do that, I suppose I can reuse test demo attached as a basic for new layout test?
Mihnea Ovidenie
Comment 5 2013-06-03 04:14:11 PDT
(In reply to comment #4) > I will do that, I suppose I can reuse test demo attached as a basic for new layout test? Sure. Some of the layout tests in fast/regions use a script, check-layout.js, it may be a good idea to use it for this test instead of writing a ref test.
Anton Obzhirov
Comment 6 2013-06-05 05:38:18 PDT
Created attachment 203811 [details] Patch
Dave Hyatt
Comment 7 2013-06-13 08:22:24 PDT
Comment on attachment 203811 [details] Patch r=me
WebKit Commit Bot
Comment 8 2013-06-13 09:49:30 PDT
Comment on attachment 203811 [details] Patch Clearing flags on attachment: 203811 Committed r151554: <http://trac.webkit.org/changeset/151554>
WebKit Commit Bot
Comment 9 2013-06-13 09:49:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.