Bug 111087

Summary: [Mac] use HAVE() macro instead of version check
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, dino, ojan.autocc, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2013-02-28 09:55:37 PST
Define HAVE_MEDIA_ACCESSIBILITY_FRAMEWORK so we can use HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK) instead of testing __MAC_OS_X_VERSION_XXX directly.
Attachments
Proposed patch (5.82 KB, patch)
2013-02-28 10:19 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-02-28 09:55:50 PST
<rdar://problem/13315073>
Eric Carlson
Comment 2 2013-02-28 10:19:45 PST
Created attachment 190748 [details] Proposed patch
WebKit Review Bot
Comment 3 2013-02-28 11:37:13 PST
Comment on attachment 190748 [details] Proposed patch Clearing flags on attachment: 190748 Committed r144336: <http://trac.webkit.org/changeset/144336>
WebKit Review Bot
Comment 4 2013-02-28 11:37:16 PST
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 5 2013-02-28 14:04:53 PST
Comment on attachment 190748 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=190748&action=review > Source/WebCore/page/PageGroup.cpp:42 > -#if PLATFORM(MAC) && !PLATFORM(IOS) > +#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK) Reverted this and > Source/WebCore/page/PageGroup.cpp:423 > -#if PLATFORM(MAC) && !PLATFORM(IOS) > +#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK) this in r144367 to fix media/video-controls-captions-trackmenu-sorted.html.
Note You need to log in before you can comment on or make changes to this bug.