Bug 111087

Summary: [Mac] use HAVE() macro instead of version check
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, dino, ojan.autocc, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Description Eric Carlson 2013-02-28 09:55:37 PST 
Define HAVE_MEDIA_ACCESSIBILITY_FRAMEWORK so we can use HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK) instead of testing __MAC_OS_X_VERSION_XXX directly.
Comment 1 Radar WebKit Bug Importer 2013-02-28 09:55:50 PST 
<rdar://problem/13315073>
Comment 2 Eric Carlson 2013-02-28 10:19:45 PST 
Created attachment 190748 [details]
Proposed patch
Comment 3 WebKit Review Bot 2013-02-28 11:37:13 PST 
Comment on attachment 190748 [details]
Proposed patch

Clearing flags on attachment: 190748

Committed r144336: <http://trac.webkit.org/changeset/144336>
Comment 4 WebKit Review Bot 2013-02-28 11:37:16 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryosuke Niwa 2013-02-28 14:04:53 PST 
Comment on attachment 190748 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190748&action=review

> Source/WebCore/page/PageGroup.cpp:42
> -#if PLATFORM(MAC) && !PLATFORM(IOS)
> +#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)

Reverted this and

> Source/WebCore/page/PageGroup.cpp:423
> -#if PLATFORM(MAC) && !PLATFORM(IOS)
> +#if HAVE(MEDIA_ACCESSIBILITY_FRAMEWORK)

this in r144367 to fix media/video-controls-captions-trackmenu-sorted.html.