| Summary: | Web Inspector: Adding existing key in DOMStorageItemsView leaves it inconsistent state | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Vivek Galatage <vivekg> | ||||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Vivek Galatage <vivekg> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 190687 [details]
Patch
Comment on attachment 190687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190687&action=review > Source/WebCore/inspector/front-end/DOMStorageItemsView.js:149 > + if (!keyFound) { Please use early returns as extensively as possible. It improves the code readability and makes it [a bit more] error-proof. if (keyFound) { childNode.removeSelf(); continue; } keyFound = true; childNode.data.value = storageData.newValue; childNode.refresh(); childNode.select(); childNode.reveal(); this.deleteButton.visible = true; Created attachment 190691 [details]
Patch
Comment on attachment 190691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=190691&action=review > Source/WebCore/inspector/front-end/DOMStorageItemsView.js:150 > + childNode.parent.removeChild(childNode); Sorry for missing this. You can replace "childNode.parent" by "rootNode", right? Created attachment 190692 [details]
Patch
Created attachment 190694 [details]
Patch
Comment on attachment 190694 [details] Patch Clearing flags on attachment: 190694 Committed r144317: <http://trac.webkit.org/changeset/144317> All reviewed patches have been landed. Closing bug. |
Steps: 1. Create some local storage entries. e.g. { "item1": "value1", "item2": "value2", ... } 2. Navigate to Resources panel and localStorage view 3. Using the last row of the grid (creation node), just enter the value to be one of the existing keys [ "key1", "key2" ... ] 4. Press enter Expected outcome: Only one entry per key should be shown Actual Outcome: Multiple entries are listed Patch follows.