Bug 11106

Summary: Some XMLHttpRequest URI resolving tests fail
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: XMLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: annevk, emacemac7, jchaffraix
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://tc.labs.opera.com/apis/XMLHttpRequest/open/
Attachments:
Description Flags
Change URI resolution to use the ScriptExecutionContext instead of the DOMWindow
none
Updated with Darin & Alexey's comment - Removed FIXME + removed layout test wrapper none

Alexey Proskuryakov
Reported 2006-10-01 03:33:49 PDT
The bug URL points to URI resolving tests written for the XHR spec; WebKit fails some of them.
Attachments
Change URI resolution to use the ScriptExecutionContext instead of the DOMWindow (22.07 KB, patch)
2008-12-22 11:04 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Updated with Darin & Alexey's comment - Removed FIXME + removed layout test wrapper (29.10 KB, patch)
2008-12-22 14:40 PST, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2008-12-22 11:04:57 PST
Created attachment 26207 [details] Change URI resolution to use the ScriptExecutionContext instead of the DOMWindow
Darin Adler
Comment 2 2008-12-22 12:42:44 PST
Comment on attachment 26207 [details] Change URI resolution to use the ScriptExecutionContext instead of the DOMWindow > + // The Document can use its encoding to resolve the URI so use its specialized method. > + // FIXME: Once the encoding information have been moved to ScriptExecutionContext, > + // this code should be simplified. Why not put a virtual completeURL function into ScriptExecutionContext now, even if it doesn't handle encoding correctly yet? I don't see the point in adding this if statement.
Julien Chaffraix
Comment 3 2008-12-22 14:40:24 PST
Created attachment 26213 [details] Updated with Darin & Alexey's comment - Removed FIXME + removed layout test wrapper After some discussion with Alexey, the layout test wrapper is not necessary and was removed. To address Darin's comment, I have added a non-virtual completeURL method to ScriptExecutionContext that wraps the call virtualCompleteURL (in the same way it was done for ScriptExecutionContext::url()).
Darin Adler
Comment 4 2008-12-22 15:26:05 PST
Comment on attachment 26213 [details] Updated with Darin & Alexey's comment - Removed FIXME + removed layout test wrapper r=me
Alexey Proskuryakov
Comment 5 2008-12-23 00:43:04 PST
As promised on IRC, I verified that IE7 passes these tests (and Julien tested with Firefox). Of the subsequent tests that are not included in this patch, IE7 fails 016, 024, 030 and 033.
Julien Chaffraix
Comment 6 2008-12-23 11:04:39 PST
Comment on attachment 26213 [details] Updated with Darin & Alexey's comment - Removed FIXME + removed layout test wrapper Landed patch in r39453.
Julien Chaffraix
Comment 7 2008-12-23 11:38:51 PST
Comment on attachment 26213 [details] Updated with Darin & Alexey's comment - Removed FIXME + removed layout test wrapper Clearing review flag per Alexey request.
Julien Chaffraix
Comment 8 2008-12-23 15:20:48 PST
Here are the results of the remaining tests: Tests that we fail: - 015 - 016 - 024 - 030 (throw NETWORK_ERR) - 031 - 033 Test that Firefox fails: - 015 - 016 (throw NS_ERROR_FAILURE) - 019 - 020 - 022 - 024 - 030 (throw NS_ERROR_FAILURE) - 031 - 033 (throw NS_ERROR_FAILURE in the iframe) Opera: - 015 - 016 (throw INVALID_STATE_ERR) - 021 - 023 - 024 - 025 - 030 (throw security violation) - 031 - 032 - 033
Julien Chaffraix
Comment 9 2008-12-23 15:31:45 PST
To follow the standard and match IE, we thus have to fix 015 and 031.
Anne van Kesteren
Comment 10 2023-05-12 22:56:42 PDT
These tests have been obsoleted by WPT.
Note You need to log in before you can comment on or make changes to this bug.