Bug 111053

Summary: Web Inspector: Evaluate removing fallback to old-style $() behavior.
Product: WebKit Reporter: Mike West <mkwst>
Component: Web Inspector (Deprecated)Assignee: Mike West <mkwst>
Status: RESOLVED LATER    
Severity: Normal CC: apavlov, graouts, joepeck, keishi, loislo, pfeldman, pmuellr, timothy, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 92648    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Mike West
Reported 2013-02-28 01:33:43 PST
In https://bugs.webkit.org/show_bug.cgi?id=92648, we changed the behavior of $ and $$ in the console. To ease developers into the change, we added a fallback to the previous behavior, along with console warning. It's been about 6 months since we landed that change. Perhaps we should falling back to the old behavior?
Attachments
Patch (3.38 KB, patch)
2013-02-28 02:24 PST, Mike West 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2013-02-28 02:24:21 PST
Created attachment 190685 [details] Patch
Mike West
Comment 2 2013-02-28 02:26:09 PST
If there's agreement that it's been long enough for the warning to have done it's work, the attached patch should take care of things.
Pavel Feldman
Comment 3 2013-02-28 03:30:01 PST
Comment on attachment 190685 [details] Patch I don't think the new way is popular enough yet. I'd leave it there for another year - it does not hurt.
Mike West
Comment 4 2013-02-28 04:13:04 PST
*sigh*
Timothy Hatcher
Comment 5 2013-02-28 07:53:38 PST
Some browsers also haven't shipped the original change yet…
Note You need to log in before you can comment on or make changes to this bug.