Summary: | Reduce amount of rebuilding when touching networking headers | ||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||||||||||||||||||||
Component: | WebCore Misc. | Assignee: | Alexey Proskuryakov <ap> | ||||||||||||||||||||||||||
Status: | RESOLVED WORKSFORME | ||||||||||||||||||||||||||||
Severity: | Normal | CC: | abarth, benjamin, dbates, dglazkov, dino, d-r, dstockwell, eric.carlson, eric, esprehn+autocc, feature-media-reviews, fmalita, gtk-ews, gustavo, gyuyoung.kim, haraken, hta, japhet, jer.noble, jesus, macpherson, menard, mifenton, mrobinson, ojan.autocc, ossy, pdr, philn, pnormand, rakuco, rego+ews, rniwa, schenney, simon.fraser, tkent, tommyw, toyoshim, webkit-ews, webkit.review.bot, xan.lopez, zarvai | ||||||||||||||||||||||||||
Priority: | P2 | ||||||||||||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||||||
Bug Depends on: | 111150, 111167 | ||||||||||||||||||||||||||||
Bug Blocks: | |||||||||||||||||||||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2013-02-27 21:08:47 PST
Created attachment 190643 [details]
patch for EWS
I'm a bit skeptical as to whether fixing all ports is feasible based on EWS feedback alone, given how many non-WebCore files I had to tweak on Mac. I'll try iterating for a while though.
Created attachment 190645 [details]
patch for EWS
Attachment 190645 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebCore/rendering/RenderLayerFilterInfo.h:36: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/html/parser/HTMLScriptRunner.h:32: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/dom/ScriptElement.h:26: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/inspector/NetworkResourcesData.h:34: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:51: The parameter name "o" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:59: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 8 in 145 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190645 [details] patch for EWS Attachment 190645 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16811061 Comment on attachment 190645 [details] patch for EWS Attachment 190645 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16769931 Comment on attachment 190645 [details] patch for EWS Attachment 190645 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16815134 Comment on attachment 190645 [details] patch for EWS Attachment 190645 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16839136 Created attachment 190649 [details]
patch for EWS
Attachment 190649 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebCore/html/parser/HTMLScriptRunner.h:33: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 148 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190645 [details]
patch for EWS
Very exciting!
Comment on attachment 190649 [details] patch for EWS Attachment 190649 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16815146 Comment on attachment 190649 [details] patch for EWS Attachment 190649 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16837084 Created attachment 190652 [details]
patch for EWS
Attachment 190652 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/chromium/src/ApplicationCacheHost.cpp', u'Source/WebKit/chromium/src/WebFrameImpl.h', u'Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 2 in 153 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190652 [details] patch for EWS Attachment 190652 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16836092 Comment on attachment 190652 [details] patch for EWS Attachment 190652 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16821125 Comment on attachment 190652 [details] patch for EWS Attachment 190652 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16821126 Comment on attachment 190652 [details] patch for EWS Attachment 190652 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16678246 Created attachment 190657 [details]
patch for EWS
Attachment 190657 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/v8/ScriptController.cpp', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/efl/ErrorsEfl.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', u'Source/WebCore/platform/gtk/PasteboardHelper.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/platform/qt/PasteboardQt.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/chromium/src/ApplicationCacheHost.cpp', u'Source/WebKit/chromium/src/AssociatedURLLoader.cpp', u'Source/WebKit/chromium/src/WebDataSourceImpl.cpp', u'Source/WebKit/chromium/src/WebFrameImpl.h', u'Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 2 in 160 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190657 [details] patch for EWS Attachment 190657 [details] did not pass qt-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16837103 Comment on attachment 190657 [details] patch for EWS Attachment 190657 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16839166 Comment on attachment 190657 [details] patch for EWS Attachment 190657 [details] did not pass qt-wk2-ews (qt): Output: http://webkit-commit-queue.appspot.com/results/16678260 Comment on attachment 190657 [details] patch for EWS Attachment 190657 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16820156 Created attachment 190660 [details]
patch for EWS
Attachment 190660 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/v8/ScriptController.cpp', u'Source/WebCore/bindings/v8/V8DOMWindowShell.cpp', u'Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/efl/ErrorsEfl.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', u'Source/WebCore/platform/gtk/PasteboardHelper.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/platform/qt/PasteboardQt.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/chromium/src/ApplicationCacheHost.cpp', u'Source/WebKit/chromium/src/AssociatedURLLoader.cpp', u'Source/WebKit/chromium/src/WebDataSourceImpl.cpp', u'Source/WebKit/chromium/src/WebFrameImpl.h', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 2 in 165 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190660 [details] patch for EWS Attachment 190660 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16753189 Comment on attachment 190660 [details] patch for EWS Attachment 190660 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16836120 Created attachment 190666 [details]
patch for EWS
Efl has a non-trivial build failure in WebKit2, and it looks like the build was failing before my patch too. I do not intend to include further fixes for this port.
Attachment 190666 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/v8/ScriptController.cpp', u'Source/WebCore/bindings/v8/V8DOMWindowShell.cpp', u'Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/efl/ErrorsEfl.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', u'Source/WebCore/platform/gtk/ErrorsGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardHelper.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/platform/qt/PasteboardQt.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/chromium/src/ApplicationCacheHost.cpp', u'Source/WebKit/chromium/src/AssociatedURLLoader.cpp', u'Source/WebKit/chromium/src/WebDataSourceImpl.cpp', u'Source/WebKit/chromium/src/WebFrameImpl.h', u'Source/WebKit/chromium/src/WebNode.cpp', u'Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 169 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190666 [details] patch for EWS Attachment 190666 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16837130 Comment on attachment 190666 [details] patch for EWS Attachment 190666 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16771943 Comment on attachment 190666 [details] patch for EWS Attachment 190666 [details] did not pass gtk-ews (gtk): Output: http://webkit-commit-queue.appspot.com/results/16850013 Comment on attachment 190666 [details] patch for EWS Attachment 190666 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16678286 Created attachment 190672 [details]
patch for EWS
Attachment 190672 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/v8/ScriptController.cpp', u'Source/WebCore/bindings/v8/V8DOMWindowShell.cpp', u'Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFileSystemAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/efl/ErrorsEfl.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', u'Source/WebCore/platform/gtk/ErrorsGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardHelper.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/platform/qt/PasteboardQt.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/chromium/src/ApplicationCacheHost.cpp', u'Source/WebKit/chromium/src/AssociatedURLLoader.cpp', u'Source/WebKit/chromium/src/SharedWorkerRepository.cpp', u'Source/WebKit/chromium/src/WebDataSourceImpl.cpp', u'Source/WebKit/chromium/src/WebFrameImpl.h', u'Source/WebKit/chromium/src/WebNode.cpp', u'Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 172 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190672 [details] patch for EWS Attachment 190672 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16834060 Comment on attachment 190672 [details] patch for EWS Attachment 190672 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16786103 Comment on attachment 190672 [details] patch for EWS Attachment 190672 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16851007 Created attachment 190866 [details]
patch for EWS
Attachment 190866 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/v8/ScriptController.cpp', u'Source/WebCore/bindings/v8/V8DOMWindowShell.cpp', u'Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFileSystemAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/chromium/CachedRawResourceChromium.cpp', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/efl/ErrorsEfl.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', u'Source/WebCore/platform/gtk/ErrorsGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardHelper.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/platform/qt/PasteboardQt.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/chromium/src/ApplicationCacheHost.cpp', u'Source/WebKit/chromium/src/AssociatedURLLoader.cpp', u'Source/WebKit/chromium/src/EditorClientImpl.cpp', u'Source/WebKit/chromium/src/SharedWorkerRepository.cpp', u'Source/WebKit/chromium/src/WebDataSourceImpl.cpp', u'Source/WebKit/chromium/src/WebFrameImpl.h', u'Source/WebKit/chromium/src/WebNode.cpp', u'Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 174 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 190870 [details]
patch for EWS
I really appreciate your tenacity here. Paying back this long-term technical debt is important IMO. :) Also, I'm sorry the style-queue is so horribly optimized for this. I think changing the output to include the full command line should be considered a regression and fixed. Attachment 190870 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/v8/ScriptController.cpp', u'Source/WebCore/bindings/v8/V8DOMWindowShell.cpp', u'Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFileSystemAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/chromium/CachedRawResourceChromium.cpp', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/PointerLockController.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/efl/ErrorsEfl.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', u'Source/WebCore/platform/gtk/ErrorsGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardHelper.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/platform/qt/PasteboardQt.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/chromium/src/ApplicationCacheHost.cpp', u'Source/WebKit/chromium/src/AssociatedURLLoader.cpp', u'Source/WebKit/chromium/src/EditorClientImpl.cpp', u'Source/WebKit/chromium/src/SharedWorkerRepository.cpp', u'Source/WebKit/chromium/src/WebDataSourceImpl.cpp', u'Source/WebKit/chromium/src/WebFrameImpl.h', u'Source/WebKit/chromium/src/WebNode.cpp', u'Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp', u'Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1
Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 3 in 176 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190870 [details] patch for EWS Attachment 190870 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/16663484 Comment on attachment 190870 [details] patch for EWS Attachment 190870 [details] did not pass chromium-ews (chromium-xvfb): Output: http://webkit-commit-queue.appspot.com/results/16826187 Created attachment 190875 [details]
patch for EWS
Attachment 190875 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/v8/ScriptController.cpp', u'Source/WebCore/bindings/v8/V8DOMWindowShell.cpp', u'Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFileSystemAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/chromium/CachedRawResourceChromium.cpp', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/PointerLockController.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/efl/ErrorsEfl.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', u'Source/WebCore/platform/gtk/ErrorsGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardHelper.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/platform/qt/PasteboardQt.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/testing/MockPagePopupDriver.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/chromium/src/ApplicationCacheHost.cpp', u'Source/WebKit/chromium/src/AssociatedURLLoader.cpp', u'Source/WebKit/chromium/src/EditorClientImpl.cpp', u'Source/WebKit/chromium/src/SharedWorkerRepository.cpp', u'Source/WebKit/chromium/src/WebDataSourceImpl.cpp', u'Source/WebKit/chromium/src/WebFrameImpl.h', u'Source/WebKit/chromium/src/WebNode.cpp', u'Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp', u'Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp', u'Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp']" exit_code: 1
Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp:36: Alphabetical sorting problem. [build/include_order] [4]
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 4 in 178 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 190886 [details]
patch for review
Attachment 190886 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp', u'Source/WebCore/Modules/notifications/Notification.cpp', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.gypi', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/ScriptControllerBase.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/ScriptController.cpp', u'Source/WebCore/bindings/js/ScriptSourceCode.h', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/v8/ScriptController.cpp', u'Source/WebCore/bindings/v8/V8DOMWindowShell.cpp', u'Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp', u'Source/WebCore/css/CSSCrossfadeValue.h', u'Source/WebCore/css/CSSFontFaceSource.h', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp', u'Source/WebCore/css/WebKitCSSSVGDocumentValue.h', u'Source/WebCore/dom/Clipboard.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/DOMImplementation.cpp', u'Source/WebCore/dom/PendingScript.h', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/ScriptElement.h', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/html/DOMURL.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/ImageDocument.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/MediaDocument.cpp', u'Source/WebCore/html/PluginDocument.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLParserOptions.cpp', u'Source/WebCore/html/parser/HTMLScriptRunner.h', u'Source/WebCore/html/parser/XSSAuditor.cpp', u'Source/WebCore/html/parser/XSSAuditorDelegate.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFileSystemAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorPageAgent.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/inspector/NetworkResourcesData.h', u'Source/WebCore/loader/CookieJar.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.cpp', u'Source/WebCore/loader/CrossOriginAccessControl.h', u'Source/WebCore/loader/CrossOriginPreflightResultCache.h', u'Source/WebCore/loader/DocumentThreadableLoader.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/loader/FrameLoader.h', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/ImageLoader.h', u'Source/WebCore/loader/LinkLoader.h', u'Source/WebCore/loader/MainResourceLoader.cpp', u'Source/WebCore/loader/MainResourceLoader.h', u'Source/WebCore/loader/MixedContentChecker.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/loader/PolicyChecker.h', u'Source/WebCore/loader/ProgressTracker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/SubresourceLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.cpp', u'Source/WebCore/loader/TextTrackLoader.h', u'Source/WebCore/loader/ThreadableLoader.h', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp', u'Source/WebCore/loader/appcache/ApplicationCacheGroup.h', u'Source/WebCore/loader/appcache/ApplicationCacheHost.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/loader/cache/CachedFont.cpp', u'Source/WebCore/loader/cache/CachedFont.h', u'Source/WebCore/loader/cache/CachedFontClient.h', u'Source/WebCore/loader/cache/CachedImage.cpp', u'Source/WebCore/loader/cache/CachedRawResource.cpp', u'Source/WebCore/loader/cache/CachedRawResource.h', u'Source/WebCore/loader/cache/CachedRawResourceClient.h', u'Source/WebCore/loader/cache/CachedResource.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.cpp', u'Source/WebCore/loader/cache/CachedResourceHandle.h', u'Source/WebCore/loader/cache/CachedSVGDocument.h', u'Source/WebCore/loader/cache/CachedSVGDocumentClient.h', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.cpp', u'Source/WebCore/loader/cache/CachedSVGDocumentReference.h', u'Source/WebCore/loader/cache/CachedStyleSheetClient.h', u'Source/WebCore/loader/cache/MemoryCache.cpp', u'Source/WebCore/loader/cache/MemoryCache.h', u'Source/WebCore/loader/chromium/CachedRawResourceChromium.cpp', u'Source/WebCore/loader/icon/IconController.cpp', u'Source/WebCore/loader/icon/IconLoader.h', u'Source/WebCore/loader/mac/ResourceLoaderMac.mm', u'Source/WebCore/page/DOMWindowExtension.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/PerformanceNavigation.cpp', u'Source/WebCore/page/PerformanceTiming.cpp', u'Source/WebCore/page/PointerLockController.cpp', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/animation/CSSPropertyAnimation.cpp', u'Source/WebCore/platform/chromium/PasteboardChromium.cpp', u'Source/WebCore/platform/efl/ErrorsEfl.cpp', u'Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp', u'Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h', u'Source/WebCore/platform/graphics/filters/FilterOperation.cpp', u'Source/WebCore/platform/graphics/filters/FilterOperation.h', u'Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp', u'Source/WebCore/platform/gtk/ErrorsGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/gtk/PasteboardHelper.h', u'Source/WebCore/platform/mac/ClipboardMac.h', u'Source/WebCore/platform/mac/ClipboardMac.mm', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/platform/network/AuthenticationChallengeBase.cpp', u'Source/WebCore/platform/network/cf/CookieJarCFNet.cpp', u'Source/WebCore/platform/network/cf/ResourceRequestCFNet.cpp', u'Source/WebCore/platform/network/mac/CookieStorageMac.mm', u'Source/WebCore/platform/qt/PasteboardQt.cpp', u'Source/WebCore/plugins/DOMMimeType.cpp', u'Source/WebCore/plugins/PluginRequest.h', u'Source/WebCore/plugins/PluginStream.h', u'Source/WebCore/plugins/PluginStreamClient.h', u'Source/WebCore/plugins/PluginView.cpp', u'Source/WebCore/plugins/PluginView.h', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderEmbeddedObject.cpp', u'Source/WebCore/rendering/RenderImage.cpp', u'Source/WebCore/rendering/RenderImageResource.cpp', u'Source/WebCore/rendering/RenderImageResource.h', u'Source/WebCore/rendering/RenderImageResourceStyleImage.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderSnapshottedPlugIn.cpp', u'Source/WebCore/rendering/RenderTableCol.cpp', u'Source/WebCore/rendering/RenderTableRow.cpp', u'Source/WebCore/rendering/RenderTableSection.cpp', u'Source/WebCore/rendering/style/StyleCachedShader.h', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.cpp', u'Source/WebCore/rendering/style/StyleCustomFilterProgram.h', u'Source/WebCore/svg/SVGFEImageElement.h', u'Source/WebCore/svg/SVGFontFaceUriElement.h', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGUseElement.h', u'Source/WebCore/svg/graphics/SVGImageCache.cpp', u'Source/WebCore/testing/MockPagePopupDriver.cpp', u'Source/WebCore/xml/XSLStyleSheet.h', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.h', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/chromium/ChangeLog', u'Source/WebKit/chromium/src/ApplicationCacheHost.cpp', u'Source/WebKit/chromium/src/AssociatedURLLoader.cpp', u'Source/WebKit/chromium/src/EditorClientImpl.cpp', u'Source/WebKit/chromium/src/SharedWorkerRepository.cpp', u'Source/WebKit/chromium/src/WebDataSourceImpl.cpp', u'Source/WebKit/chromium/src/WebFrameImpl.h', u'Source/WebKit/chromium/src/WebNode.cpp', u'Source/WebKit/chromium/src/WebSharedWorkerImpl.cpp', u'Source/WebKit/chromium/tests/FrameLoaderClientImplTest.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/DOM/WebDOMOperations.mm', u'Source/WebKit/mac/Misc/WebNSPasteboardExtras.mm', u'Source/WebKit/mac/WebCoreSupport/WebFrameNetworkingContext.mm', u'Source/WebKit/mac/WebView/WebRenderLayer.mm', u'Source/WebKit/mac/WebView/WebRenderNode.mm', u'Source/WebKit/qt/ChangeLog', u'Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/NetworkProcess/HostRecord.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoadScheduler.h', u'Source/WebKit2/NetworkProcess/NetworkResourceLoader.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebContextMenuClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm', u'Source/WebKit2/WebProcess/WebProcess.cpp', u'Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp']" exit_code: 1
Source/WebCore/loader/DocumentThreadableLoader.h:46: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebCore/loader/cache/CachedResourceHandle.h:33: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 2 in 185 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 190886 [details] patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=190886&action=review LGTM. I'm curious to read any tips/tricks you learned about how to go about such a compile-time reduction as you did. Did you just keep touching a header and see how many files it built? > Source/WebCore/page/Frame.h:219 > + mutable OwnPtr<FrameLoader> m_loader; I wonder if this still needs to be mutable. > LGTM. I'm curious to read any tips/tricks you learned about how to go about such a compile-time reduction as you did. Did you just keep touching a header and see how many files it built? Most of the time, I've been measuring how many files Xcode wanted to reindex, although that's imprecise. As for finding how to improve things, preprocessing .cpp files was invaluable. > > Source/WebCore/page/Frame.h:219 > > + mutable OwnPtr<FrameLoader> m_loader; > > I wonder if this still needs to be mutable. I think that it did need to be, yes. Thank you for review! Thank you again for the awesome cleanup! Comment on attachment 190886 [details] patch for review Clearing flags on attachment: 190886 Committed r144422: <http://trac.webkit.org/changeset/144422> All reviewed patches have been landed. Closing bug. Comment on attachment 190886 [details] patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=190886&action=review > Source/WebKit/chromium/src/WebFrameImpl.h:45 > +class FrameLoadRequest; FrameLoadRequest is a struct Re-opened since this is blocked by bug 111167 If the patch will be re-landed after fixing, please take care of ifdef sections, because r144422 caused the following build issue on Qt Minimal build: make[2]: *** [.obj/release-shared/bindings/js/JSCallbackData.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from /ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings/js/JSMainThreadExecState.h:29:0, from /ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp:34: /ramdisk/qt-linux-release-minimal/build/Source/WebCore/inspector/InspectorInstrumentation.h:200:141: error: 'HTTPHeaderMap' does not name a type /ramdisk/qt-linux-release-minimal/build/Source/WebCore/inspector/InspectorInstrumentation.h:200:154: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive] In file included from /ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings/js/JSMainThreadExecState.h:29:0, from /ramdisk/qt-linux-release-minimal/build/Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp:34: /ramdisk/qt-linux-release-minimal/build/Source/WebCore/inspector/InspectorInstrumentation.h:1496:204: error: 'HTTPHeaderMap' does not name a type /ramdisk/qt-linux-release-minimal/build/Source/WebCore/inspector/InspectorInstrumentation.h:1496:219: error: ISO C++ forbids declaration of 'headers' with no type [-fpermissive] ICECC[22356] 12:41:51: Compiled on 160.114.36.234 make[2]: *** [.obj/release-shared/bindings/js/JSCustomXPathNSResolver.o] Error 1 http://build.webkit.org/builders/Qt%20Linux%20Release%20minimal/builds/73371 Re-landed in <http://trac.webkit.org/r144530>. > Re-opened since this is blocked by bug 111167 I am not at all sure that the claim in bug 111167 is accurate. I could not find Chromium Win Debug on build.webkit.org to confirm it. Does this build style even have a bot? If not, rolling out due to failures on it should be a very rare exception, and should be accompanied with very detailed analysis of what went wrong. Data in bug 111167 is not actionable. > If the patch will be re-landed after fixing, please take care of ifdef sections, because r144422 caused the following build issue on Qt Minimal build: I fixed this particular issue. Do you have a suggestion about how one could avoid breaking Qt minimal build? I don't think that its feasible to guess what tweaks it could require. It appears that this patch regressed html5-full-render by roughly 400%: https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22Chromium%20Linux%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Chromium%20Mac%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Chromium%20Win%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22EFL%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Mac%20Lion%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Mac%20MountainLion%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Qt%205.0%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%2C%5B%22Qt%205.0%20WebKit%202%22%2C%22Parser%2Fhtml5-full-render%3ATime%22%5D%5D (In reply to comment #61) > It appears that this patch regressed html5-full-render by roughly 400%: Sorry, this was a false alarm. It was an issue with perf.webkit.org itself. The problem has been diagnosed and the store data has been corrected accordingly. Also, landed following Windows build fix patches (sorry, I made a mess): http://trac.webkit.org/changeset/144534 http://trac.webkit.org/changeset/144536 http://trac.webkit.org/changeset/144537 http://trac.webkit.org/changeset/144538 http://trac.webkit.org/changeset/144540 > I am not at all sure that the claim in bug 111167 is accurate. The claim is accurate. > I could not find Chromium Win Debug on build.webkit.org to confirm it. The builder is located on at this URL: http://build.chromium.org/p/chromium.webkit/waterfall?show=WebKit%20Win7%20(dbg)(1) > Does this build style even have a bot? Yes. Please do not break the Chromium port. Here’s the build before the landed was initially landed (WebKit r144421): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29%281%29/builds/3235 The build immediately after the patch (WebKit r144425; ignore the blame list. it’s wrong): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29%281%29/builds/3236 Before rollout (WebKit r144445): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29%281%29/builds/3240 After rollout (WebKit r144447): http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29%281%29/builds/3241 I rolled out this patch again in <http://trac.webkit.org/changeset/144565>. I convinced rniwa on IRC that the patch did cause these ASSERTs. Please do no re-land this patch without fixing the ASSERTs. Patches are not permitted to break non-WebKit2 ports. As I'm sure you're aware, Chromium is not a WebKit2 port. I realize that this policy makes large-scale refactorings like this patch more difficult. However, we will not have a functioning project if we go around breaking each other's code. Ideally, toyoshim would have provided links to the ASSERTs in bug 111167. However, the correct course of action for Alexey in this situation would have been to ask someone on #webkit for the URL of the chromium-win debug bot. Every contributor to the Chromium port knows where these bots are and would have been able to show them to Alexey. Alexey, this is not the first time you've tried to steamroll in a patch that breaks the Chromium port. My patience with your behavior is rapidly evaporating. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29%281%29/builds/3255 had WebKit@144564, which was just before the rollout, and contained the ASSERT failures. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29%281%29/builds/3256 had WebKit@144571, which was the next build after the rollout, and the ASSERTs where gone. I'm very grateful to the many people who helped with this patch. Unfortunately, I think that it's blocked until a chromium engineer has a chance to more constructively look into what's going on with this builder. (In reply to comment #60) [snip] > > If the patch will be re-landed after fixing, please take care of ifdef sections, because r144422 caused the following build issue on Qt Minimal build: > > I fixed this particular issue. Do you have a suggestion about how one could avoid breaking Qt minimal build? I don't think that its feasible to guess what tweaks it could require. Thanks for the fix, the minimal bot was happy after it. Just to make it clear, Qt minimal name isn't the best naming. It isn't a real world configuration, but a good configuration (simple --minimal option added to build-webkit) to catch broken enable/use/... ifded guards. It isn't so important not breaking it as the other high traffic platforms. But it would be great if we can fix it after a build breakage to be able signal broken ifdefs again. The stack trace for the chromium crashes is below. I'm still trying to understand exactly what's happening. I'll look at it more tomorrow.
> DumpRenderTree.exe!WebCore::ResourceRequestBase::updateResourceRequest(WebCore::HTTPBodyUpdatePolicy bodyPolicy) Line 517 + 0x32 bytes C++
DumpRenderTree.exe!WebCore::ResourceRequestBase::url() Line 123 C++
DumpRenderTree.exe!WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction(void (WebCore::PolicyAction)* function, const WebCore::NavigationAction & action, const WebCore::ResourceRequest & request, WTF::PassRefPtr<WebCore::FormState> formState) Line 999 + 0x1b bytes C++
DumpRenderTree.exe!WebCore::PolicyChecker::checkNavigationPolicy(const WebCore::ResourceRequest & request, WebCore::DocumentLoader * loader, WTF::PassRefPtr<WebCore::FormState> formState, void (void *, const WebCore::ResourceRequest &, WTF::PassRefPtr<WebCore::FormState>, bool)* function, void * argument) Line 99 C++
DumpRenderTree.exe!WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader * loader, WebCore::FrameLoadType type, WTF::PassRefPtr<WebCore::FormState> prpFormState) Line 1408 C++
DumpRenderTree.exe!WebCore::FrameLoader::load(WebCore::DocumentLoader * newDocumentLoader) Line 1348 C++
DumpRenderTree.exe!WebCore::FrameLoader::load(const WebCore::FrameLoadRequest & passedRequest) Line 1298 C++
DumpRenderTree.exe!WebKit::WebFrameImpl::loadRequest(const WebKit::WebURLRequest & request) Line 954 + 0x41 bytes C++
DumpRenderTree.exe!WebViewHost::navigate(const TestNavigationEntry & entry, bool reload) Line 860 + 0x27 bytes C++
DumpRenderTree.exe!TestNavigationController::navigateToPendingEntry(bool reload) Line 264 + 0x25 bytes C++
DumpRenderTree.exe!TestNavigationController::loadEntry(TestNavigationEntry * entry) Line 138 C++
DumpRenderTree.exe!WebViewHost::loadURLForFrame(const WebKit::WebURL & url, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & frameName) Line 716 + 0x46 bytes C++
DumpRenderTree.exe!WebViewHost::shutdown() Line 759 + 0x54 bytes C++
DumpRenderTree.exe!TestShell::~TestShell() Line 169 C++
DumpRenderTree.exe!main(int argc, char * * argv) Line 274 C++
Is it possible that this was caused by some linker error? We occasionally see crashes on Apple Windows port where the only way to fix it is to trigger a clean build. Also, can you reproduce these crashes locally? (In reply to comment #70) > Is it possible that this was caused by some linker error? We occasionally see crashes on Apple Windows port where the only way to fix it is to trigger a clean build. > > Also, can you reproduce these crashes locally? I reproduced it locally, yes. I stepped through with a debugger, and found that things went wrong in the initialization of FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction. When it tried to access the "const ResourceRequest& request" parameter it received, it used the wrong offset into the stack. It accessed a stack memory address 12 bytes off from the correct address (on a 32-bit build). Since that address wasn't actually a pointer to a ResourceRequest, the dereference was garbage and we crash. That certainly sounds like it could be a toolchain bug. The only other idea I have is that the #include changes somehow ended up pulling a .h for another platform and therefore the allocation size for some object on the stack was wrong. However, I don't see any local variables in FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction that could cause that problem, and I think an allocation of the wrong size would have to happen there. > The only other idea I have is that the #include changes somehow ended up pulling a .h for another platform
Perhaps we should add #error statements to these headers to catch such issues?
Most of these changes got landed by Anders and myself already, and remaining smaller bits will use separate bugs. |