Bug 111019

Summary: REGRESSION(r144168): It broke the build and tronical is unavailable (Requested by Ossy_night on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, ossy, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
ROLLOUT of r144168 none

Description WebKit Review Bot 2013-02-27 15:35:10 PST
http://trac.webkit.org/changeset/144168 broke the build:
It broke the build and tronical is unavailable (Requested by Ossy_night on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2013-02-27 15:35:33 PST
Created attachment 190619 [details]
ROLLOUT of r144168

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Csaba Osztrogonác 2013-02-27 15:45:05 PST
Sorry guys, but you were unavailable after landing and it broke the build:

/Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/LLIntOffsetsExtractor.pro:62: 'activeBuildConfig' is not a recognized replace function.
/Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/LLIntOffsetsExtractor.pro:63: 'activeBuildConfig' is not a recognized replace function.
make -f Makefile.LLIntOffsetsExtractor
ruby /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm /LLIntDesiredOffsets.h
offlineasm: Parsing /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and creating offset extractor /LLIntDesiredOffsets.h.
offlineasm: Including file /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm
offlineasm: Including file /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm
/Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:107:in `initialize': Permission denied - /LLIntDesiredOffsets.h (Errno::EACCES)
	from /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:107:in `open'
	from /Users/admin/work/WebKit-BuildSlave/qt-mountainlion-release/build/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:107
make[3]: *** [/LLIntDesiredOffsets.h] Error 1
make[2]: *** [sub-LLIntOffsetsExtractor-pro-make_for_qmake] Error 2
make[1]: *** [sub-Source-JavaScriptCore-JavaScriptCore-pro-qmake_all] Error 2
make: *** [incremental] Error 2
Comment 3 WebKit Review Bot 2013-02-27 15:52:35 PST
Comment on attachment 190619 [details]
ROLLOUT of r144168

Clearing flags on attachment: 190619

Committed r144249: <http://trac.webkit.org/changeset/144249>
Comment 4 WebKit Review Bot 2013-02-27 15:52:38 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2013-02-27 15:54:07 PST
Reopen, because only rollout fixed, the original bug is still waiting for fix.
Comment 6 Simon Hausmann 2013-02-27 23:19:04 PST
(In reply to comment #2)
> Sorry guys, but you were unavailable after landing and it broke the build:

Ouch, I'm very sorry :(
Comment 7 Simon Hausmann 2013-02-28 01:42:18 PST
The issue was that this was a forward-port where the source (Qt 5.0.1) the activeBuildConfig() function was still existent. In the meanwhile it was renamed to $$targetSubDir() in trunk. Updated patch landed in http://trac.webkit.org/changeset/144279