Bug 110974 – REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator

• Component: Forms
• Status: RESOLVED FIXED

[Kent Tamura]

<input type=date style="display:inline-block;">

has 2-lines height and the second line contains only calendar picker arrow.

Twitter bootstrap adds display:inline-block by default.


https://code.google.com/p/chromium/issues/detail?id=178175

[Kent Tamura]

Created attachment 190500 [details]
Screenshot

[Kent Tamura]

Created attachment 190502 [details]
Patch

[WebKit Review Bot]

Attachment 190502 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/forms/date/date-appearance-basic-expected.txt', u'LayoutTests/fast/forms/date/date-appearance-basic.html', u'LayoutTests/platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png', u'LayoutTests/platform/chromium/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp', u'Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h']" exit_code: 1
LayoutTests/platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kentaro Hara]

Comment on attachment 190502 [details]
Patch

rs=me

[WebKit Review Bot]

Comment on attachment 190502 [details]
Patch

Clearing flags on attachment: 190502

Committed r144184: <http://trac.webkit.org/changeset/144184>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

(In reply to comment #5)
> (From update of attachment 190502 [details])
> Clearing flags on attachment: 190502
> 
> Committed r144184: <http://trac.webkit.org/changeset/144184>

I found the flexible box didn't work well with this change.  I'm reverting.

[Kent Tamura]

Reverted r144184 for reason:

The change didn't fix all of the problems.

Committed r144271: <http://trac.webkit.org/changeset/144271>

[Kent Tamura]

Created attachment 190710 [details]
Patch 2

[WebKit Review Bot]

Attachment 190710 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/forms/date/date-appearance-basic-expected.txt', u'LayoutTests/fast/forms/date/date-appearance-basic.html', u'LayoutTests/platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png', u'LayoutTests/platform/chromium/TestExpectations', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/html.css', u'Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp', u'Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/InputType.h']" exit_code: 1
LayoutTests/platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:0:  Have to enable auto props in the subversion config file (/home/alancutter/.subversion/config "enable-auto-props = yes"). Have to set the svn:mime-type in the subversion config file (/home/alancutter/.subversion/config "*.png = svn:mime-type=image/png").  [image/png] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kentaro Hara]

Comment on attachment 190710 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=190710&action=review

> Source/WebCore/html/HTMLInputElement.cpp:-1968
> -    if (!m_inputType->shouldApplyLocaleDirection())
> -        return originalStyle.release();

Why do you want to remove shouldApplyLocaleDirection() from the new code?

[Kent Tamura]

Comment on attachment 190710 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=190710&action=review

>> Source/WebCore/html/HTMLInputElement.cpp:-1968
>> -        return originalStyle.release();
> 
> Why do you want to remove shouldApplyLocaleDirection() from the new code?

I converted shouldApplyLocaleDirection to another virtual function, InputType::customStyleForRenderer.
Only BaseMultipleFieldsDateAndTimeInputType returns true for shouldApplyLocaleDirection. So we can move the code followed by "if (...shouldApplyLocaleDirection())" to BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer.

[Kentaro Hara]

Comment on attachment 190710 [details]
Patch 2

ah, I got it. Looks OK to me.

[WebKit Review Bot]

Comment on attachment 190710 [details]
Patch 2

Clearing flags on attachment: 190710

Committed r144352: <http://trac.webkit.org/changeset/144352>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dirk Pranke]

updated the baseline for fast/forms/date/date-appearance-basic.html