Bug 110955

Summary: Web Inspector: timeline stops working on certain sites
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Eugene Klyuchnikov <eustas>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, caseq, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Yury Semikhatsky 2013-02-27 00:31:39 PST
User report:

"I've noticed that timeline stops working on certain sites.

F.ex. go to www.tv2.dk, start timeline recording.

Now, only a few events are shown in the list, and after stopping recording, the slider at the top is not working (list of events is not updated when sliding in the timeline).

Also, it is not possible to start recording again. Only if I close developer tools and open them again.

I actually noticed this a while ago in Canary, but I assumed it would be fixed before hitting release.

Anyone else having this problem?"
Comment 1 Yury Semikhatsky 2013-02-27 00:33:20 PST
There is an exception in the console if you open inspector on inspector:

Uncaught Error: NotFoundError: DOM Exception 8 View.js:478
Element.removeChild View.js:478
WebInspector.TimelinePanel._refreshRecords TimelinePanel.js:868
WebInspector.TimelinePanel._refresh TimelinePanel.js:771
Comment 2 Yury Semikhatsky 2013-02-27 00:40:59 PST
WebInspector.TimelinePresentationModel.Record.detailsNode (TimelinePresentationModel.js:1005)
WebInspector.TimelineRecordListRow.update (TimelinePanel.js:1383)
WebInspector.TimelinePanel._refreshRecords (TimelinePanel.js:904)
WebInspector.TimelinePanel._refresh (TimelinePanel.js:771)
Comment 3 Eugene Klyuchnikov 2013-02-27 01:30:11 PST
Created attachment 190465 [details]
Patch
Comment 4 Alexander Pavlov (apavlov) 2013-02-27 01:50:50 PST
Comment on attachment 190465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=190465&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        Analysis: "timerId" value is number,

Seems like a drawback of untyped payloads...
Comment 5 Eugene Klyuchnikov 2013-02-27 02:15:31 PST
(In reply to comment #4)
> (From update of attachment 190465 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=190465&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:8
> > +        Analysis: "timerId" value is number,
> 
> Seems like a drawback of untyped payloads...

We're thinking about making them typed =)
Comment 6 WebKit Review Bot 2013-02-27 02:17:04 PST
Comment on attachment 190465 [details]
Patch

Clearing flags on attachment: 190465

Committed r144161: <http://trac.webkit.org/changeset/144161>
Comment 7 WebKit Review Bot 2013-02-27 02:17:08 PST
All reviewed patches have been landed.  Closing bug.